Extend Webhook autoscaler to send fleet metadata with the request #3951
Comments
|
Seems legit to me! I assume, name, annotations and labels? |
|
That is correct. I was looking into the code and found that the easiest way to add these was to put the whole metadata into the request, but I do like the idea of making that payload smaller |
|
🤔 it would make the code easier to grab the entire metadata object and chuck it across. If you're implementing it, I'll let you decide 😄 |
|
I've added a PR, let me know what you think 😄 |
|
'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions ' |
github-actions
bot
added
the
stale
|
PR seems to be in flight. @swermin are you still working on this? |
|
Hi! Yes I am, or I was. Sorry it took some time for this whole thing. Last few weeks have been busy so I didn’t have time to get to implementing e2e tests. My plan was to try wrap it up these coming days. I have a general question though, do I need to make a new PR to get the example autoscaler to support this flow? Or is it about to get the fixes in and some one to help me get a new container image built to test with? |
Nope, you can add them to the exiting PR.
ooh, good question. Yeah, likely with help. Have a think about what is needed for the e2e tests, and if you need a new container or not for it. |
github-actions
bot
removed
the
stale
Is your feature request related to a problem? Please describe.
We are running our fleets throughout different clusters and independently of one and other and use the webhook autoscaler to make sure that we have necessary sizes on all the fleets.
With this solution we are allocating game servers based on labels and not on fleet names, this means that on the
webhook autoscalerendpoint we have no idea to determine the size since the request does not contain any metadata at all regarding the fleet in question.Describe the solution you'd like
We want to extend the
FleetAutoscaleRequestto include the fleet metadata when reporting to the service(s).Describe alternatives you've considered
We made changes to the URL used for the
webhookbut that means that we have to update the URL every time we add new label and/or annotationsThe text was updated successfully, but these errors were encountered: