Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing tsconfig.json from npm package #2190

Open
MegaManSec opened this issue Mar 7, 2025 · 2 comments
Open

[Bug]: Missing tsconfig.json from npm package #2190

MegaManSec opened this issue Mar 7, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@MegaManSec
Copy link

Version

v5

Reanimated Version

v3

Gesture Handler Version

v2

Platforms

iOS

What happened?

When downloading react-native-bottom-sheet from NPM, the tsconfig.json is missing from the package making reproducing the package impossible. Can it be included?

Reproduction steps

Download the package on npm
Run yarn && yarn build

tsc will error out due to the missing file

Reproduction sample

https://snack.expo.dev/@joromybk/bottom-sheet---issue-reproduction-template

Relevant log output

N/A
@MegaManSec MegaManSec added the bug Something isn't working label Mar 7, 2025
@gorhom
Copy link
Owner

gorhom commented Mar 9, 2025

Hi @MegaManSec , you can use the package snack template or simply download the package from github

@MegaManSec
Copy link
Author

MegaManSec commented Mar 10, 2025

That's true, but given that it is nearly possible to build it from the npmjs package, why not include the file so you can simply run yarn build from the official package?

The npmjs package may differ from the GitHub codebase - building the js code from the ts in the official package is a valuable construct imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants