Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Testing support? #41

Open
skynyrd opened this issue Apr 23, 2017 · 12 comments · May be fixed by #123
Open

Testing support? #41

skynyrd opened this issue Apr 23, 2017 · 12 comments · May be fixed by #123

Comments

@skynyrd
Copy link

skynyrd commented Apr 23, 2017

Hi, Thank you for the project, I really like the idea.
I use React + Redux for about a year however I don't feel very comfortable with testing.

Are tests going to be implemented?

Thanks

@EricSimons
Copy link
Member

Great suggestion! @kentcdodds actually created some for this repo + the node repo over at https://github.com/kentcdodds/testing-workshop.

Maybe we could convince him to make a PR back here at some point :) 🙏

@skynyrd
Copy link
Author

skynyrd commented Apr 24, 2017

That would be great :)

@kentcdodds
Copy link

Perhaps! Though I did make a number of changes to make the code more testable. 🙃

@EricSimons
Copy link
Member

EricSimons commented Apr 24, 2017

In that case, we'd love to have those changes PR'd 🙌😄

@kentcdodds
Copy link

I'm sure! It's unlikely I'll get around to it, but maybe someone who takes the workshop will be inspired :)

@justDanielMata
Copy link

@EricSimons I wrote some unit tests and changed a little bit of code to be more clean, i would love to write a full test suite for this, should i pr the initial tests so you see if they are okay before moving on?

@EricSimons
Copy link
Member

@justDanielMata yes absolutely!! 🙌

@justDanielMata
Copy link

@EricSimons i'm probably dumb, but it is the first time i create a pull request for an oss project, how do i create the pr? it says i'm inauthorized on my terminal.

@EricSimons
Copy link
Member

@justDanielMata github actually has a button in the UI that will automatically do that PR for you — where is your current forked repo located?

@justDanielMata
Copy link

justDanielMata commented Jun 7, 2017 via email

@EricSimons
Copy link
Member

Yup! Heres some more info on how to do it: https://stackoverflow.com/questions/14680711/how-to-do-a-github-pull-request

@leosuncin leosuncin linked a pull request Oct 25, 2018 that will close this issue
@by12380
Copy link

by12380 commented Jul 21, 2020

Is the effort on adding tests still going on?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants