Skip to content
This repository has been archived by the owner on Sep 8, 2021. It is now read-only.

Your Feed pagination broken, not adding offset #197

Open
cirosantilli opened this issue Jun 18, 2021 · 0 comments
Open

Your Feed pagination broken, not adding offset #197

cirosantilli opened this issue Jun 18, 2021 · 0 comments

Comments

@cirosantilli
Copy link

cirosantilli commented Jun 18, 2021

This repo at 9186292

Create new user, login, add 11 followers with at least one article then visit / to see "Your Feed" (articles by users you follow).

Pagination has e.g. 2 pages.

The first page looks fine, from Chrome developer tools Network tab we see a /api/articles/feed?limit=10&offset=0 API hit as expected.

However, when you click on the second page button 2, it fetches again /api/articles/feed?limit=10&offset=0 instead of the expected /api/articles/feed?limit=10&offset=10.

And whatever it is the version that is running at https://react-redux.realworld.io actually returns global data for the second page from /api/articles?limit=10&offset=10.

This was not solved by #161

Tested at https://github.com/cirosantilli/node-express-sequelize-realworld-example-app/tree/74401f159c9aa2a417bb4e0911afbab162f29082 with test data generation ./bin/generate-demo-data.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant