Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namelist based configuration #15

Open
bolding opened this issue Feb 15, 2021 · 7 comments
Open

Remove namelist based configuration #15

bolding opened this issue Feb 15, 2021 · 7 comments

Comments

@bolding
Copy link
Collaborator

bolding commented Feb 15, 2021

Remove all namelist based configuration except for turbulence and util (used by external 3D models - notably FVCOM). Maintaining the namelists configuration will be time consuming and error-prone and will not benefit the work done on GOTM being able to generate its own configuration. In addition we will remove many 100 lines of obsolete code. Included will also be the removal of all the .xml based code and files.

@adolfstips
Copy link

Seems you forgot to say the obvious, that instead yaml configuration will be used?
As long as 'some configuration" will be possible, and only the double procedure/possibility
will be removed, this is fine for me,..

@hburchard
Copy link
Contributor

I fully agree. Specifically since the yaml files are nicely and clearly commented.

@bolding
Copy link
Collaborator Author

bolding commented Mar 3, 2021

as Jorn just pointed out:

BTW this will break GOTM-GUI compat

@jornbr
Copy link
Contributor

jornbr commented Mar 3, 2021

Yes, to elaborate: GOTM-GUI would need a significant update to deal with yaml configuration and such an update is currently not planned. But in my opinion that should not stop the clean-up of GOTM. To deal with this I'd propose to point GOTM-GUI explicitly to the latest GOTM that still includes nml support (v6), likely be adding GOTM as submodule in the GOTM-GUI repository.

@bolding
Copy link
Collaborator Author

bolding commented Mar 4, 2021

I've created the nonml branch - https://github.com/gotm-model/code/tree/nonml

Please have a look and help remove all traces of namelist.

git difftool -y ..master - might be your friend

I've grepped for namelist, _nml, nml and namlst - and most of those are removed.

The new code passes the automatic tests - except for gfortran6 (but that is a different issue).

@poplarShift
Copy link

poplarShift commented Nov 24, 2023

Relatedly, is my impression correct that internally, GOTM still works with namelists, and that these are populated from the gotm.yaml file step by step throughout the code?

@bolding
Copy link
Collaborator Author

bolding commented Nov 24, 2023

no - GOTM works with YAML formatted configuration files - .https://yaml.org/

when we moved from namelists to YAML we kept support for both for a while - but in the upcoming version 7 namelists will dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants