Improves offline message detection on Android

mediabounds · mediabounds · commit 73da0e14781d · 2024-07-23T15:32:46.000-05:00
diff --git a/Float.Core/Extensions/Exception.extensions.cs b/Float.Core/Extensions/Exception.extensions.cs
@@ -37,6 +37,13 @@ public static bool IsOfflineException(this Exception e)
                 return true;
             }
 
+            // On Android, the message might literally be "Connection failure"
+            // (see https://github.com/dotnet/android/blob/688245d397097fbc8e70fd291abe11143f1c3553/src/Mono.Android/Xamarin.Android.Net/AndroidMessageHandler.cs#L577)
+            if (e.Message == "Connection failure")
+            {
+                return true;
+            }
+
             // we sometimes get a webexception status of NameResolutionFailure that we don't have access to, but its enum value is one
             if (e.InnerException is WebException webException && ((int)webException.Status == 1 || webException.Status == WebExceptionStatus.ConnectFailure))
             {

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,13 @@ public static bool IsOfflineException(this Exception e)`
`37`	`37`	`return true;`
`38`	`38`	`}`
`39`	`39`
	`40`	`+ // On Android, the message might literally be "Connection failure"`
	`41`	`+ // (see https://github.com/dotnet/android/blob/688245d397097fbc8e70fd291abe11143f1c3553/src/Mono.Android/Xamarin.Android.Net/AndroidMessageHandler.cs#L577)`
	`42`	`+ if (e.Message == "Connection failure")`
	`43`	`+ {`
	`44`	`+ return true;`
	`45`	`+ }`
	`46`	`+`
`40`	`47`	`// we sometimes get a webexception status of NameResolutionFailure that we don't have access to, but its enum value is one`
`41`	`48`	`if (e.InnerException is WebException webException && ((int)webException.Status == 1 \|\| webException.Status == WebExceptionStatus.ConnectFailure))`
`42`	`49`	`{`