Pytorch Profiler#76
Closed
AndreSlavescu wants to merge 1 commit intogpu-mode:mainfrom
Closed
Conversation
Collaborator
|
@AndreSlavescu The only problem I see with this is that it implicitly just wraps a profiler around the top of a file, but this can be problematic if someone just submits a standard kernel file that's formatted as a bunch of functions (you'll have to be explicit about this). Like basically this only works if someone submits a file that doesn't run. I need to give this more thought, @S1ro1 maybe you have better thoughts. Can you instead make sure for now that profiling function goes into say the if name == "main"? |
alexzhang13
requested changes
Dec 26, 2024
Collaborator
alexzhang13
left a comment
There was a problem hiding this comment.
For now, can you make it so the PyTorch profiler goes inside say if __name__ == '__main__'? also make sure it indents properly so it actually runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief summary of the changes in this pull request.
Checklist
Before submitting this PR, ensure the following steps have been completed:
/verifyrunson your own server./verifyruns.runs may take a little longer. The Modal run is typically quick.)
For more information on running a cluster bot on your own server, see
README.md.