Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tags are not duplicates during bookmark load #1166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pinkavaj
Copy link
Contributor

@pinkavaj pinkavaj commented Nov 8, 2022

Duplicates can be introduced in several ways. User can add duplicate
tag now, but it seems tath past and current GQRX contains some bugs
related to bookmarks/tags and the saved content is sometimes crappy.

@pinkavaj
Copy link
Contributor Author

pinkavaj commented Nov 8, 2022

Is it ok to add such refactors, or should I create separate MR? (I would do it for bigger ones for sure).

@vladisslav2011
Copy link
Contributor

vladisslav2011 commented Nov 8, 2022

I think, it is better to switch to using shared pointers instead of raw pointers for taginfo. It solves tag corruption when Gqrx is built with Qt6. Take a look at this PR #1145

@vladisslav2011
Copy link
Contributor

Could you open an issue and provide exact steps to reproduce tag duplication bug?

@pinkavaj
Copy link
Contributor Author

pinkavaj commented Nov 8, 2022

Could you open an issue and provide exact steps to reproduce tag duplication bug?

#1167 Thats for the manual method, I was able to create really a mess in tags, but I guess that might be accounted to the bug which #1145 is addressing.

@pinkavaj
Copy link
Contributor Author

Sure #1145 can be solved first, I does not mind to rebase.

Duplicates can be introduced in several ways. User can add duplicate
tag now, but it seems tath past and current GQRX contains some bugs
related to bookmarks/tags and the saved content is sometimes crappy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants