Consistent bookmark tags edition with single click #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0penBrain
force-pushed
the
editBookmarkTags
branch
from
91df9de
to
00b2dc3
Compare
|
Conflicts resolved and useless commit removed following merge of #1312. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at bringing consistent edition of tags attached to bookmarks, using a single click on the "Tag" field of a selected bookmark.
Commit 1 implements this with a QItemDelegate and drops code made obsolete by the change.
Commits 2 & 3 improves behavior in specific situations that wasn't introduced by this PR.
Next commits are some code fixes and cleanup.