Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Prometheus support (or at least exclusion) #61

Open
rgeyer opened this issue May 25, 2022 · 0 comments
Open

Non-Prometheus support (or at least exclusion) #61

rgeyer opened this issue May 25, 2022 · 0 comments

Comments

@rgeyer
Copy link
Collaborator

rgeyer commented May 25, 2022

When linting a dashboard which does not use prometheus targets, several linting errors will be returned.

These are not actually errors, they're just prometheus based rules being applied to non-prometheus targets and dashboards.

The linter should allow rules to opt-in to what type of panels/targets it can effectively evaluate for best practice, and simply ignore the rest.

This would mean that running the dashboard linter against a dashboard for which it has no best practices (such as query specific rules for a loki panel, as an example), no errors would be emitted.

In time, this would allow for rules specific to other datasources to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant