Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer: Set protocolTimeout #482

Open
AgnesToulet opened this issue Nov 16, 2023 · 5 comments
Open

Puppeteer: Set protocolTimeout #482

AgnesToulet opened this issue Nov 16, 2023 · 5 comments
Labels
component/puppeteer type/bug Something isn't working

Comments

@AgnesToulet
Copy link
Contributor

In "recent" version of Puppeteer, a new timeout had been added and ignore the one we can send to the image renderer. We should configure it either with the value configured in the image renderer settings (if possible) or with 0 (no timeout).

@AgnesToulet AgnesToulet added type/bug Something isn't working component/puppeteer labels Nov 16, 2023
@johndunderhill
Copy link

We are seeing strange performance problems generating PDFs. We have a generous global timeout set (10 minutes), but some of the panels are still failing randomly, and show an error in the produced PDF. The same panel may work fine on a subsequent attempt. There isn't any apparent patturn to the failures that we've been able to determine. This started in the latest version of Grafana Cloud at about the time of this issue. We are on currently on Grafana 10.3. Example:

image

Thank you for your work on the renderer and gofpdf.

@github-project-automation github-project-automation bot moved this to 🗂️ Needs Triage / Escalation in Sharing squad Sep 10, 2024
@evictorero evictorero moved this from 🗂️ Needs Triage / Escalation to 🗓️ To Do in Sharing squad Sep 10, 2024
@juanicabanas
Copy link
Contributor

Hi @johndunderhill does the issue persist, yet?
We're making a big change in the report generation process under newPDFRendering and reportingUseRawTimeRange FF. We plan to enable them by default in Grafana 11.5.
This allows creating the report by visiting the dashboard once, instead of visiting panel by panel and fixes many timeout issues.

@johndunderhill
Copy link

johndunderhill commented Dec 19, 2024 via email

@johndunderhill
Copy link

@juanicabanas In my limiting testing, everything seems to work at the moment, but I can no longer tell you what version we're on. In the user interface, it now says merely Grafana Cloud (steady) with no version information. This used to appear.

Previously, we seemed to be ahead of public releases. As of now, I'm not certain.

I am waiting to hear back from staff on whether the automated report runs have failed recently. I'll let you know if I hear anything.

@johndunderhill
Copy link

@juanicabanas The user reports no current problems but I'm not certain we're using the process you're enabling. I've looked over issues related to this and I can't make any sense out of the situation. Obviously we're concerned, but since Grafana has seen fit to obscure from us any information about what version of the software we're running, it will be difficult to anticipate any impact. I'm sorry I can't be more helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/puppeteer type/bug Something isn't working
Projects
Status: 🗓️ To Do
Development

No branches or pull requests

3 participants