Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple properties in data queries #412

Open
hwandersman opened this issue Feb 10, 2025 · 0 comments
Open

Support multiple properties in data queries #412

hwandersman opened this issue Feb 10, 2025 · 0 comments

Comments

@hwandersman
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
For the IoT SiteWise Get* queries (GetPropertyValue, GetPropertyValueHistory, GetInterpolatedValues, and GetPropertyAggregates) we support selecting multiple assets in the same asset model, but we do not support selecting multiple properties for those assets. Many IoT SiteWise customers are asking for this feature.

Describe the solution you'd like
Like we batch calls to the Get* APIs for multiple assets, we should have additional entries in the batch request for multiple properties.

Each entry to a batch data call must have at least an assetId and property OR a property alias. The scope for this feature is to support a list of assetIds and propertyIds and return data for all combinations of those ids. Every combination is valid as long as each asset is an instance of the same asset model.

The backend plugin will need to update models to accept an array of propertyIds like assetIds, then create entries for the respective batch API like here: https://github.com/grafana/iot-sitewise-datasource/blob/main/pkg/sitewise/api/property_history_batch.go#L48

The frontend plugin will need to update the propertyId field to support multiple values.

Describe alternatives you've considered
The only alternative is to create a new query for each property, which is not extensible for customers with many properties on their assets.

Additional context
N/A

@kevinwcyu kevinwcyu moved this from Incoming to Backlog in AWS Datasources Feb 11, 2025
@taleena taleena moved this from Backlog to Next in AWS Datasources Feb 11, 2025
@taleena taleena moved this from Next to Backlog in AWS Datasources Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants