Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tolerations to PrivateLoadZone objects #427

Open
aaron-lunsford-even opened this issue Jul 15, 2024 · 1 comment · May be fixed by #428
Open

Add support for tolerations to PrivateLoadZone objects #427

aaron-lunsford-even opened this issue Jul 15, 2024 · 1 comment · May be fixed by #428
Labels
enhancement New feature or request PLZ
Milestone

Comments

@aaron-lunsford-even
Copy link

Feature Description

Users can specify resource requests and limits for PrivateLoadZone objects that will populate down to runner pods for tests run in that load zone. The ability to specify tolerations would allow users to schedule these runner pods on tainted node group(s) in the cluster.

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

@aaron-lunsford-even aaron-lunsford-even added the enhancement New feature or request label Jul 15, 2024
@aaron-lunsford-even aaron-lunsford-even linked a pull request Jul 15, 2024 that will close this issue
@yorugac yorugac added the PLZ label Jul 17, 2024
@yorugac
Copy link
Collaborator

yorugac commented Jul 17, 2024

Hi @aaron-lunsford-even, thank you for opening the issue and PR! Regarding the implementation, I'll comment on the PR.

You mention "runner pods" but each test run actually has 2 small pods in addition: starter (running curl command) and initializer (running k6 inspect command). Is it correct to assume that in your use case, all pods for a specific test run should scheduled with the same tolerations?

@yorugac yorugac added this to the 0.17 milestone Jul 29, 2024
@yorugac yorugac modified the milestones: 0.17, 0.18 Oct 3, 2024
@yorugac yorugac modified the milestones: 0.18, 0.19 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PLZ
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants