Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash module #2814

Open
mwain opened this issue Dec 8, 2022 · 1 comment
Open

Hash module #2814

mwain opened this issue Dec 8, 2022 · 1 comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature ux

Comments

@mwain
Copy link

mwain commented Dec 8, 2022

Feature Description

There is a crypto module providing crypto hash functions, i would like to use non crypto hashes like ones found in hash package.

Is there a desire to add an extra module to k6 providing support for non crypto hashes?

Suggested Solution (optional)

Hash module, similar to crypto

Already existing or connected issues / PRs (optional)

No response

@mwain mwain added the feature label Dec 8, 2022
@na-- na-- added the evaluation needed proposal needs to be validated or tested before fully implementing it in k6 label Dec 12, 2022
@na--
Copy link
Member

na-- commented Dec 12, 2022

Hmm 🤔 Can you please elaborate and explain what your use case is?

I can see how something like this would be useful, and it makes some sense to have a high-speed implementation (i.e. in Go, not in JS) of these hash functions, but there are some challenges in terms of API design we need to consider before we can add them 😞

As you say, these hashes are not cryptographic, so they shouldn't be in the existing k6/crypto module or in the upcoming implementation of the WebCrypto APIs (https://github.com/grafana/xk6-webcrypto, which we plan soon merge in the k6 core, first in k6/experimental and then as a stable API).

So, yeah, I am not sure where to put them, just that a top-level k6/hash module doesn't seem like quite the right place 🤔

@na-- na-- added ux evaluation needed proposal needs to be validated or tested before fully implementing it in k6 and removed evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 feature ux
Projects
None yet
Development

No branches or pull requests

2 participants