-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tail sampling for traces #467
base: main
Are you sure you want to change the base?
Conversation
charts/k8s-monitoring/templates/alloy_config/_processors.alloy.txt
Outdated
Show resolved
Hide resolved
- also remove default value, as they have to be defined anyway based on reviews from @t00mas
charts/k8s-monitoring/templates/alloy_config/_processors.alloy.txt
Outdated
Show resolved
Hide resolved
@t00mas I applied your reviews :) Could you have another look if you find some time please 🙏 ? |
I'm OK with this, just take into account @rlankfo 's recommendation here #443 (comment) |
I'd be concerned about adding the tail sampling processor at this stage of the pipeline. It won't be scalable -- to scale the tail sampling processor we recommend introducing a load balancing exporter in a separate layer that can route traces by trace ID. @petewall do you have any thoughts here? |
Add tail sampling for traces. Useful when dropping health probes from your traces for instance, as they can be quite noisy 💸.
Documentation: https://grafana.com/docs/grafana-cloud/monitor-applications/application-observability/setup/sampling/tail/
Related issues:
Comments:
examples/tail-sampling/*.alloy
files.helm template k8s-monitoring charts/k8s-monitoring -f examples/tail-sampling/values.yaml > examples/tail-sampling/output.yaml
), but didn't tested it would work correctly.extraConfig
is working, just let the user pass any string?Note: It is really painful to work with these
alloy_config/*.alloy.txt
files 😅