Skip to content

Commit b77af06

Browse files
authored
chore: faillint usage of opentracing in make lint (#17951)
Signed-off-by: Oleg Zaytsev <[email protected]>
1 parent 917a60c commit b77af06

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

Makefile

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -373,13 +373,18 @@ else
373373
go version
374374
golangci-lint version
375375
GO111MODULE=on golangci-lint run -v --timeout 15m --build-tags linux,promtail_journal_enabled
376-
faillint \
377-
-paths "sync/atomic=go.uber.org/atomic" \
376+
faillint -paths \
377+
"sync/atomic=go.uber.org/atomic" \
378378
./...
379379

380380
# Use our spanlogger implementation instead of the one in dskit to make sure we use the correct tracing lib.
381-
faillint \
382-
-paths "github.com/grafana/dskit/spanlogger=github.com/grafana/loki/pkg/util/spanlogger" \
381+
faillint -paths \
382+
"github.com/grafana/dskit/spanlogger=github.com/grafana/loki/pkg/util/spanlogger" \
383+
./...
384+
385+
# We don't use opentracing anymore.
386+
faillint -paths \
387+
"github.com/opentracing/opentracing-go,github.com/opentracing/opentracing-go/log,github.com/uber/jaeger-client-go,github.com/opentracing-contrib/go-stdlib/nethttp" \
383388
./...
384389
endif
385390

0 commit comments

Comments
 (0)