Update error message when using disabled PromQL experimental aggregation function

zenador · zenador · commit 07d930501de0 · 2024-12-09T19:42:42.000+08:00
Signed-off-by: Jeanette Tan &lt;jeanette.tan@grafana.com&gt;
diff --git a/promql/parser/parse.go b/promql/parser/parse.go
@@ -450,7 +450,7 @@ func (p *parser) newAggregateExpr(op Item, modifier, args Node) (ret *AggregateE
 		if !EnableExperimentalFunctions && ret.Op.IsExperimentalAggregator() {
 			// In mimir we return a custom message which doesn't mention the CLI flag that should be used to enable
 			// experimental functions, given it's different (and in SaaS customers don't even have access to it).
-			p.addParseErrf(ret.PositionRange(), "limitk() and limit_ratio() functions are not enabled")
+			p.addParseErrf(ret.PositionRange(), `function "%s" is not enabled`, ret.Op)
 			return
 		}
 		desiredArgs = 2

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,7 @@ func (p parser) newAggregateExpr(op Item, modifier, args Node) (ret AggregateE`
`450`	`450`	`if !EnableExperimentalFunctions && ret.Op.IsExperimentalAggregator() {`
`451`	`451`	`// In mimir we return a custom message which doesn't mention the CLI flag that should be used to enable`
`452`	`452`	`// experimental functions, given it's different (and in SaaS customers don't even have access to it).`
`453`		`- p.addParseErrf(ret.PositionRange(), "limitk() and limit_ratio() functions are not enabled")`
	`453`	+ p.addParseErrf(ret.PositionRange(), `function "%s" is not enabled`, ret.Op)
`454`	`454`	`return`
`455`	`455`	`}`
`456`	`456`	`desiredArgs = 2`