Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Error 1 #206

Open
wademorris opened this issue Sep 25, 2024 · 3 comments
Open

[build] Error 1 #206

wademorris opened this issue Sep 25, 2024 · 3 comments
Assignees

Comments

@wademorris
Copy link

Hello!

I am receiving a build error 1 when trying to build the binary.
github.com/grafana/mimir-proxies/pkg/remoteread pkg/remoteread/api.go:142:30: cannot use v1api (variable of type "github.com/prometheus/client_golang/api/prometheus/v1".API) as API value in struct literal: "github.com/prometheus/client_golang/api/prometheus/v1".API does not implement API (wrong type for method LabelNames) have LabelNames("context".Context, []string, "time".Time, "time".Time, ..."github.com/prometheus/client_golang/api/prometheus/v1".Option) ([]string, "github.com/prometheus/client_golang/api/prometheus/v1".Warnings, error) want LabelNames("context".Context, []string, "time".Time, "time".Time) ([]string, "github.com/prometheus/client_golang/api/prometheus/v1".Warnings, error) make: *** [build] Error 1

Any ideas? TY!

Wade

@alexgreenbank
Copy link
Collaborator

Looks like this changed in prometheus/client_golang 1.20.0 (specifically https://github.com/prometheus/client_golang/pull/1544/files).

Not sure why our dependabot didn't warn us of this, we'll investigate.

@alexgreenbank alexgreenbank self-assigned this Sep 25, 2024
@alexgreenbank
Copy link
Collaborator

Does the branch in #207 work for you?

@wademorris
Copy link
Author

yep!!!
bash ./scripts/compile_commands.sh Succesfully built datadog-proxy-writes into dist/datadog-proxy-writes Succesfully built graphite-proxy-writes into dist/graphite-proxy-writes Succesfully built mimir-whisper-converter into dist/mimir-whisper-converter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants