Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tagged metrics support to whisper converter #93

Open
3 tasks
ywwg opened this issue Oct 13, 2023 · 3 comments
Open
3 tasks

Add tagged metrics support to whisper converter #93

ywwg opened this issue Oct 13, 2023 · 3 comments
Labels

Comments

@ywwg
Copy link
Member

ywwg commented Oct 13, 2023

(imported issue)

Right now the whisper converter only supports untagged metrics. We should add support for tagged metrics.

From the docs, the tags are stored in a separate database from the whisper files. So it looks like:

Tasks

Preview Give feedback
@ywwg
Copy link
Member Author

ywwg commented Oct 13, 2023

I think based on the schema we'd do a big JOIN, something like
SELECT Tag.tag FROM Tag JOIN SeriesTag ON SeriesTag.tag == Tag.id AND SeriesTag.Series == Series.id WHERE Series.path=="METRICNAME"

and then

SELECT Tag.tag, TagValue.value FROM TagValue JOIN SeriesTag ON SeriesTag.tag == Tag.id AND SeriesTag.TagValue == TagValue.id WHERE Tag.id IN "THE RESULTS FROM ABOVE"

@ywwg
Copy link
Member Author

ywwg commented Oct 13, 2023

ah, it'll be simpler than that, we don't need the tag values

@ywwg
Copy link
Member Author

ywwg commented Oct 13, 2023

hm, the db may just be for querying. the actual storage appears to be an alternative scheme: https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/tags/utils.py#L125-L134

@ywwg ywwg added the graphite label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant