Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Implement Lucene Traces in the backend #223

Closed
3 tasks done
Tracked by #192
sarahzinger opened this issue Jul 24, 2023 · 0 comments · Fixed by #257
Closed
3 tasks done
Tracked by #192

Backend: Implement Lucene Traces in the backend #223

sarahzinger opened this issue Jul 24, 2023 · 0 comments · Fixed by #257
Assignees

Comments

@sarahzinger
Copy link
Member

sarahzinger commented Jul 24, 2023

There's currently no processing of traces on the backend, only frontend. There is no equivalent PR in ElasticSearch to reference, but we have implemented this fairly recently so there are up-to-date tests and the feature looks stable.

Tasks

Preview Give feedback
  1. effort/medium
    fridgepoet
  2. effort/medium
    sarahzinger
  3. effort/medium
    idastambuk

Note: This is the case for jaeger trace format, as otel hasn't been implemented yet (#205). However, the scope of this PR is just migrating the data processing for jaeger traces that we currently have in FE and in data-prepper.

Some general guidelines are:

  • Create visualization to compare between frontend and backend flows, preferably in a shared Cloud dashboard e.g. clouddatasources.grafana.net
  • Unit tests in the frontend should be copied or updated in the backend to assert the same behavior and add unit tests when there are none.
    • Check Elasticsearch repo for related tests – helpful when there are no OpenSearch tests in the frontend or backend
  • We should match OpenSearch's backend behavior to the current frontend behavior, but be aware it may not always make sense. Elasticsearch's current behavior is also another resource for how OpenSearch should behave.
    • Let's be pragmatic about this – our foremost goal is the migration of OpenSearch's frontend behavior. We can aim for some Elasticsearch feature parity, but only within reason.
  • Migrate or implement: i.e. make any changes to code in backend
  • Use the dashboard created above to compare visualization results (data frame comparison)
    • Can also inspect data frame on a more detailed basis
@sarahzinger sarahzinger moved this from Incoming to Next in AWS Datasources Jul 24, 2023
@idastambuk idastambuk self-assigned this Aug 1, 2023
@idastambuk idastambuk moved this from Next to In Progress in AWS Datasources Aug 1, 2023
@idastambuk idastambuk moved this from In Progress to Backlog in AWS Datasources Nov 13, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in AWS Datasources Nov 17, 2023
@idastambuk idastambuk moved this from Done to Next in AWS Datasources Nov 17, 2023
@idastambuk idastambuk reopened this Nov 17, 2023
@idastambuk idastambuk moved this from Next to Backlog in AWS Datasources Nov 17, 2023
@kevinwcyu kevinwcyu assigned sarahzinger and unassigned idastambuk Nov 17, 2023
@kevinwcyu kevinwcyu moved this from Backlog to In Progress in AWS Datasources Nov 17, 2023
@sarahzinger sarahzinger moved this from In Progress to Done in AWS Datasources Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants