Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Migration: Migrate PPL Time Series to the backend #296

Closed
Tracked by #192
iwysiu opened this issue Nov 7, 2023 · 0 comments · Fixed by #367
Closed
Tracked by #192

Backend Migration: Migrate PPL Time Series to the backend #296

iwysiu opened this issue Nov 7, 2023 · 0 comments · Fixed by #367

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Nov 7, 2023

Prerequisite: #226

Some general guidelines are:

  • Create visualization to compare between frontend and backend flows, preferably in a shared Cloud dashboard e.g. clouddatasources.grafana.net
  • Unit tests in the frontend should be copied or updated in the backend to assert the same behavior and add unit tests when there are none.
    • Check Elasticsearch repo for related tests – helpful when there are no OpenSearch tests in the frontend or backend
  • We should match OpenSearch's backend behavior to the current frontend behavior, but be aware it may not always make sense. Elasticsearch's current behavior is also another resource for how OpenSearch should behave.
    • Let's be pragmatic about this – our foremost goal is the migration of OpenSearch's frontend behavior. We can aim for some Elasticsearch feature parity, but only within reason.
  • Often there is a PR in the Elasticsearch backend data source migration Elasticsearch: Convert the datasource to be a backend datasource grafana#54011 which is 75% of what OpenSearch will need
  • Migrate or implement: i.e. make any changes to code in backend
  • Use the dashboard created above to compare visualization results (data frame comparison)
    • Can also inspect data frame on a more detailed basis

Similar to #289 and #200

@github-project-automation github-project-automation bot moved this to Incoming in AWS Datasources Nov 7, 2023
@iwysiu iwysiu moved this from Incoming to Next in AWS Datasources Nov 7, 2023
@sarahzinger sarahzinger moved this from Next to Backlog in AWS Datasources Nov 13, 2023
@katebrenner katebrenner moved this from Backlog to Next in AWS Datasources Apr 1, 2024
@katebrenner katebrenner changed the title Backend: Migrate PPL Time Series to the backend Backend Migration: Migrate PPL Time Series to the backend Apr 15, 2024
@iwysiu iwysiu self-assigned this Apr 15, 2024
@iwysiu iwysiu moved this from Next to In Progress in AWS Datasources Apr 15, 2024
@iwysiu iwysiu assigned iwysiu and unassigned iwysiu Apr 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in AWS Datasources May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant