diff --git a/packages/scenes-ml/src/components/SceneBaseliner.tsx b/packages/scenes-ml/src/components/SceneBaseliner.tsx index 37550f0..d77b79f 100644 --- a/packages/scenes-ml/src/components/SceneBaseliner.tsx +++ b/packages/scenes-ml/src/components/SceneBaseliner.tsx @@ -9,7 +9,7 @@ import { ButtonGroup, Checkbox, RadioButtonGroup, Slider, ToolbarButton, Tooltip import { Duration } from 'date-fns'; import React from 'react'; -import { sceneGraph, SceneComponentProps, SceneObjectState, SceneObjectUrlValues, SceneObjectBase, SceneObjectUrlSyncConfig, ExtraQueryDescriptor, ExtraQueryProvider, ExtraQueryDataProcessor } from "@grafana/scenes"; +import { sceneGraph, SceneComponentProps, SceneObjectState, SceneObjectBase, ExtraQueryDescriptor, ExtraQueryProvider, ExtraQueryDataProcessor } from "@grafana/scenes"; import { of } from "rxjs"; Promise.all([ @@ -95,7 +95,6 @@ export class SceneBaseliner extends SceneObjectBase implements ExtraQueryProvider { public static Component = SceneBaselinerRenderer; - protected _urlSync = new SceneObjectUrlSyncConfig(this, { keys: ['discoverSeasonalities', 'interval', 'trainingLookbackFactor'] }); public latestData?: PanelData; public constructor(state: Partial) { @@ -143,15 +142,6 @@ export class SceneBaseliner extends SceneObjectBase return false; } - // Get the URL state for the component. - public getUrlState(): SceneObjectUrlValues { - return { - interval: this.state.interval?.toString(), - discoverSeasonalities: this.state.discoverSeasonalities?.toString(), - trainingLookbackFactor: this.state.trainingLookbackFactor?.toString(), - }; - } - public onModelTypeChanged(modelType: ModelType) { this.setState({ model: modelType }); } @@ -179,51 +169,6 @@ export class SceneBaseliner extends SceneObjectBase public setLatestData(data: PanelData) { this.latestData = data; } - - // Update the component state from the URL. - public updateFromUrl(values: SceneObjectUrlValues) { - if (!values.trainingLookbackFactor && !values.interval) { - return; - } - let factor: number | undefined; - if (typeof values.trainingLookbackFactor === 'string') { - factor = parseInt(values.trainingLookbackFactor, 10); - } else if (values.trainingLookbackFactor instanceof Array) { - factor = parseInt(values.trainingLookbackFactor[0], 10); - } - let interval: number | undefined; - if (typeof values.interval === 'string') { - interval = parseInt(values.interval, 10); - } else if (values.interval instanceof Array) { - interval = parseInt(values.interval[0], 10); - } - let discoverSeasonalities: boolean | undefined; - if (typeof values.discoverSeasonalities === 'string') { - discoverSeasonalities = values.discoverSeasonalities === 'true'; - } else if (values.discoverSeasonalities instanceof Array) { - discoverSeasonalities = values.discoverSeasonalities[0] === 'true'; - } - const stateUpdate: Partial = {}; - if (factor) { - const options = DEFAULT_TRAINING_FACTOR_OPTIONS; - if (options.find(({ value }) => value === factor)) { - stateUpdate.trainingLookbackFactor = factor; - } else { - stateUpdate.trainingLookbackFactor = DEFAULT_TRAINING_FACTOR_OPTION.value; - } - } - if (interval) { - stateUpdate.interval = interval; - } else { - stateUpdate.interval = DEFAULT_INTERVAL; - } - if (discoverSeasonalities) { - stateUpdate.discoverSeasonalities = discoverSeasonalities; - } else { - stateUpdate.discoverSeasonalities = false; - } - this.setState(stateUpdate); - } } // The transformation function for the baseliner. diff --git a/packages/scenes-ml/src/components/SceneChangepointDetector.tsx b/packages/scenes-ml/src/components/SceneChangepointDetector.tsx index 501190f..731f39a 100644 --- a/packages/scenes-ml/src/components/SceneChangepointDetector.tsx +++ b/packages/scenes-ml/src/components/SceneChangepointDetector.tsx @@ -7,7 +7,7 @@ import { of } from "rxjs"; init().then(() => console.log('augurs changepoints initialized')); -import { SceneComponentProps, SceneObjectState, SceneObjectUrlValues, SceneObjectBase, SceneObjectUrlSyncConfig, ExtraQueryDataProcessor, ExtraQueryProvider, ExtraQueryDescriptor } from "@grafana/scenes"; +import { SceneComponentProps, SceneObjectState, SceneObjectBase, ExtraQueryDataProcessor, ExtraQueryProvider, ExtraQueryDescriptor } from "@grafana/scenes"; export interface Changepoint { idx: number @@ -43,8 +43,6 @@ export class SceneChangepointDetector extends SceneObjectBase { public static Component = SceneChangepointDetectorRenderer; - protected _urlSync = new SceneObjectUrlSyncConfig(this, { keys: ['changepointLookbackFactor', 'changepointEnabled'] }); - public constructor(state: Partial) { super({ lookbackFactorOptions: DEFAULT_LOOKBACK_FACTOR_OPTIONS, ...state }); } @@ -80,14 +78,6 @@ export class SceneChangepointDetector extends SceneObjectBase = {}; - if (factor) { - const options = DEFAULT_LOOKBACK_FACTOR_OPTIONS; - if (options.find(({ value }) => value === factor)) { - stateUpdate.lookbackFactor = factor; - } else { - stateUpdate.lookbackFactor = DEFAULT_LOOKBACK_FACTOR_OPTION.value; - } - } - if (enabled) { - stateUpdate.enabled = enabled; - } - this.setState(stateUpdate); - } } // The transformation function for the changepoint detector. diff --git a/packages/scenes-ml/src/components/SceneOutlierDetector.tsx b/packages/scenes-ml/src/components/SceneOutlierDetector.tsx index 98c3080..c36adc1 100644 --- a/packages/scenes-ml/src/components/SceneOutlierDetector.tsx +++ b/packages/scenes-ml/src/components/SceneOutlierDetector.tsx @@ -4,7 +4,7 @@ import { DataFrame, DataQueryRequest, FieldType, GrafanaTheme2, PanelData, color import { DataTopic, FieldColorModeId } from "@grafana/schema"; import { ButtonGroup, Checkbox, RadioButtonGroup, Slider, ToolbarButton, Tooltip, useStyles2 } from "@grafana/ui"; -import { SceneComponentProps, SceneObjectState, SceneObjectUrlValues, SceneObjectBase, SceneObjectUrlSyncConfig, ExtraQueryProvider, ExtraQueryDescriptor } from "@grafana/scenes"; +import { SceneComponentProps, SceneObjectState, SceneObjectBase, ExtraQueryProvider, ExtraQueryDescriptor } from "@grafana/scenes"; import { css, cx } from '@emotion/css'; import { of } from 'rxjs'; @@ -49,7 +49,6 @@ export class SceneOutlierDetector extends SceneObjectBase { public static Component = SceneOutlierDetectorRenderer; - protected _urlSync = new SceneObjectUrlSyncConfig(this, { keys: ['outlierSensitivity', 'outlierAddAnnotations'] }); private latestData: PanelData | undefined; // The most recent detector instance. @@ -126,42 +125,6 @@ export class SceneOutlierDetector extends SceneObjectBase = {}; - if (sensitivity) { - stateUpdate.sensitivity = sensitivity; - } else { - stateUpdate.sensitivity = DEFAULT_SENSITIVITY; - } - if (addAnnotations) { - stateUpdate.addAnnotations = addAnnotations; - } else { - stateUpdate.addAnnotations = true; - } - this.setState(stateUpdate); - } } function createDetector(algorithm: OutlierDetectorAlgorithm, data: DataFrame, sensitivity: number): LoadedOutlierDetector { diff --git a/packages/scenes-ml/src/components/SceneTimeSeriesClusterer.tsx b/packages/scenes-ml/src/components/SceneTimeSeriesClusterer.tsx index bacea35..401ba89 100644 --- a/packages/scenes-ml/src/components/SceneTimeSeriesClusterer.tsx +++ b/packages/scenes-ml/src/components/SceneTimeSeriesClusterer.tsx @@ -5,7 +5,7 @@ import { DataFrame, DataQueryRequest, FieldType, GrafanaTheme2, PanelData, outer import { FieldColorModeId } from "@grafana/schema"; import { ButtonGroup, Checkbox, Slider, ToolbarButton, Tooltip, useStyles2 } from "@grafana/ui"; -import { SceneComponentProps, SceneObjectState, SceneObjectUrlValues, SceneObjectBase, SceneObjectUrlSyncConfig, ExtraQueryProvider, ExtraQueryDescriptor } from "@grafana/scenes"; +import { SceneComponentProps, SceneObjectState, SceneObjectBase, ExtraQueryProvider, ExtraQueryDescriptor } from "@grafana/scenes"; import { css, cx } from '@emotion/css'; import { of } from 'rxjs'; @@ -23,7 +23,6 @@ export class SceneTimeSeriesClusterer extends SceneObjectBase { public static Component = SceneTimeSeriesClustererRenderer; - protected _urlSync = new SceneObjectUrlSyncConfig(this, { keys: ['clusterepsilon'] }); private latestData: PanelData | undefined; private clusters: Record | undefined; @@ -84,31 +83,6 @@ export class SceneTimeSeriesClusterer extends SceneObjectBase = {}; - if (epsilon) { - stateUpdate.epsilon = epsilon; - } else { - stateUpdate.epsilon = DEFAULT_EPSILON; - } - this.setState(stateUpdate); - } } interface Cluster {