Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tk export broken on Windows #1055

Open
systemtrap opened this issue Jun 4, 2024 · 6 comments · May be fixed by #1058
Open

tk export broken on Windows #1055

systemtrap opened this issue Jun 4, 2024 · 6 comments · May be fixed by #1058

Comments

@systemtrap
Copy link

Since #841 tk export breaks on Windows.

godirwalk changed its behavior in karrick/godirwalk#68. godirwalk seems unmaintained as karrick/godirwalk#70 is an open issue for more than a year.
@zerok
Copy link
Contributor

zerok commented Jun 5, 2024

Thank you for reporting this 🙂

Judging by the code that uses godirwalk the reason for adding it was performance implications of filepath.Walk. IMO it would be worth a try to benchmark the current implementation against one using filepath.WalkDir and switch to that if they are at least comparable.

@zerok zerok linked a pull request Jun 7, 2024 that will close this issue
Open
@zerok
Copy link
Contributor

zerok commented Jun 11, 2024

@systemtrap if you have the time, could you perhaps please try #1058 if that works for you?

@JkLondon JkLondon mentioned this issue Jul 22, 2024
Merged
@systemtrap
Copy link
Author

I'm sorry., I missed the message. I'll check in the next couple of days.

@zerok
Copy link
Contributor

zerok commented Sep 20, 2024

No worries and thank you 🙂

@systemtrap
Copy link
Author

Works fine for me.

@zerok
Copy link
Contributor

zerok commented Oct 1, 2024

Awesome, thank you :) Then this will probably make it into the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Tanka
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace godirwalk with filepath.WalkDir grafana/tanka
2 participants
@zerok @systemtrap