{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":32039560,"defaultBranch":"master","name":"navigation","ownerLogin":"grahammendick","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-03-11T20:27:48.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1761227?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1722676679.0","currentOid":""},"activityList":{"items":[{"before":"ba2338ee02352b76a81c729a2336ada05e6eb04d","after":null,"ref":"refs/heads/action-bar","pushedAt":"2024-08-03T09:17:59.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"}},{"before":"9a330df702eba56de7e68f781482436e392bdf52","after":"1b604872e6a1c00237a1e8a46b4a8a483e997f93","ref":"refs/heads/master","pushedAt":"2024-08-03T09:17:40.000Z","pushType":"pr_merge","commitsCount":61,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Merge pull request #793 from grahammendick/action-bar","shortMessageHtmlLink":"Merge pull request #793 from grahammendick/action-bar"}},{"before":"ba83c6b7e90e68e03d18da8a5669991a362aff6d","after":"ba2338ee02352b76a81c729a2336ada05e6eb04d","ref":"refs/heads/action-bar","pushedAt":"2024-08-02T15:33:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Typed the drawer component","shortMessageHtmlLink":"Typed the drawer component"}},{"before":"67630ba6aa54ccc668380eb8fc71c40f8a286302","after":"ba83c6b7e90e68e03d18da8a5669991a362aff6d","ref":"refs/heads/action-bar","pushedAt":"2024-08-02T14:08:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Added empty Drawer native comps for ios fabric","shortMessageHtmlLink":"Added empty Drawer native comps for ios fabric"}},{"before":"1621bf94dfa1b8c34750dbc280f67267257ed91b","after":"67630ba6aa54ccc668380eb8fc71c40f8a286302","ref":"refs/heads/action-bar","pushedAt":"2024-08-01T18:50:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Added new props to the native specs","shortMessageHtmlLink":"Added new props to the native specs"}},{"before":"e533e41158418803772159a58338662550e2455d","after":"1621bf94dfa1b8c34750dbc280f67267257ed91b","ref":"refs/heads/action-bar","pushedAt":"2024-08-01T18:44:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Reverted redundant change\n\nThis happened when added the drawer open and close strings for the toggle. But since removed so don't want this showing up in the diff","shortMessageHtmlLink":"Reverted redundant change"}},{"before":"84d89363dc45e8d15dc2f91f28c308f3c5cda503","after":"e533e41158418803772159a58338662550e2455d","ref":"refs/heads/action-bar","pushedAt":"2024-08-01T18:43:31.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Ensured the drawer view renders\n\nDon't know why it's different on fabric but it rendered very wrong","shortMessageHtmlLink":"Ensured the drawer view renders"}},{"before":"cf513eef81ae239ca879158eaf12c7f538f8fedb","after":"84d89363dc45e8d15dc2f91f28c308f3c5cda503","ref":"refs/heads/action-bar","pushedAt":"2024-07-31T16:18:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Rendered drawer as pass-through on ios\n\nThere's no native drawer on ios so render children so it doesn't fall over","shortMessageHtmlLink":"Rendered drawer as pass-through on ios"}},{"before":"ae8277c04266122c00d2668945eec1f65225b1c2","after":"cf513eef81ae239ca879158eaf12c7f538f8fedb","ref":"refs/heads/action-bar","pushedAt":"2024-07-29T22:30:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Implemented Drawer in unit test\n\nModelled on Sheet so allows user to fire the changeOpen to open and close it","shortMessageHtmlLink":"Implemented Drawer in unit test"}},{"before":"0b77993e84a11be9a58eedc4492cd7a78d659731","after":"ae8277c04266122c00d2668945eec1f65225b1c2","ref":"refs/heads/action-bar","pushedAt":"2024-07-29T15:41:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Used pattern variable to remove android warnings\n\nAutomatically refactored by android studio","shortMessageHtmlLink":"Used pattern variable to remove android warnings"}},{"before":"91c3d83b7609f4ca32ebd8fa9c300fae15b66f3e","after":"0b77993e84a11be9a58eedc4492cd7a78d659731","ref":"refs/heads/action-bar","pushedAt":"2024-07-29T15:39:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Opitimized imports","shortMessageHtmlLink":"Opitimized imports"}},{"before":"48f06139ef1976b4680f86964f99f3d4720028d3","after":"91c3d83b7609f4ca32ebd8fa9c300fae15b66f3e","ref":"refs/heads/action-bar","pushedAt":"2024-07-29T15:39:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Ensured navigation image tinted by default\n\nThe default navigation icon tint is null - at least on the DayNight.NoActionBar material3 theme. This is confusing for new users because it looks like the image isn't there. So defaulted to black if null. It's not null on bottombar and searchbar so leaving them.\nAlso switched to BlendModeColorFilter to avoid deprecation warning","shortMessageHtmlLink":"Ensured navigation image tinted by default"}},{"before":"502dcdc615d4251409fe96ae8a9ea6baff484573","after":"48f06139ef1976b4680f86964f99f3d4720028d3","ref":"refs/heads/action-bar","pushedAt":"2024-07-28T20:04:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Reverted because need to think more\n\nThe bottom bar has a default tint - maybe it's a theme thing. If gonna set one need to make sure it's restored too if the tintColor prop is removed","shortMessageHtmlLink":"Reverted because need to think more"}},{"before":"7f5e4d6905f10160b10ac1b9fc24d869c4ea45a9","after":"502dcdc615d4251409fe96ae8a9ea6baff484573","ref":"refs/heads/action-bar","pushedAt":"2024-07-28T19:52:26.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Applied accessibility label to bottom bar nav","shortMessageHtmlLink":"Applied accessibility label to bottom bar nav"}},{"before":"de0755fc42adf2cd91390e6467133e0f2a065cfb","after":"7f5e4d6905f10160b10ac1b9fc24d869c4ea45a9","ref":"refs/heads/action-bar","pushedAt":"2024-07-28T17:57:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Removed android studio warnings","shortMessageHtmlLink":"Removed android studio warnings"}},{"before":"564a64402a402e9cf7977e78391370badfef096a","after":"de0755fc42adf2cd91390e6467133e0f2a065cfb","ref":"refs/heads/action-bar","pushedAt":"2024-07-28T16:41:02.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Removed drawer string values\n\nUsed navigationAccessibilityLabel prop instead - obviously better to use prop so user can control text. Tested can dynamically change prop when drawer open status changes","shortMessageHtmlLink":"Removed drawer string values"}},{"before":"19e086ff3feaa2c34543ecbe25a9124b1992e14f","after":"564a64402a402e9cf7977e78391370badfef096a","ref":"refs/heads/action-bar","pushedAt":"2024-07-28T13:56:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Removed redundant code\n\nNot relevant now always setting the navigation icon. Also this code wouldn't work when doing the drawer toggle because that happens later so don't know at this stage what to do with the listener","shortMessageHtmlLink":"Removed redundant code"}},{"before":"27d6c1f94a4025c7bddd1cfd61a3fdf4189ba4d2","after":"19e086ff3feaa2c34543ecbe25a9124b1992e14f","ref":"refs/heads/action-bar","pushedAt":"2024-07-27T20:17:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Copied auto nav default changes to bottom app bar\n\nHaven't tested them yet but needs to match the navigation bar","shortMessageHtmlLink":"Copied auto nav default changes to bottom app bar"}},{"before":"c8256e36e9d1ed7573e8e2f41290237334fd7bad","after":"27d6c1f94a4025c7bddd1cfd61a3fdf4189ba4d2","ref":"refs/heads/action-bar","pushedAt":"2024-07-27T19:01:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Removed redundant navigationDecorative\n\nIt's the same as autoNavigation - true if there's no onNavigationPress and false otherwise - so don't need it anymore","shortMessageHtmlLink":"Removed redundant navigationDecorative"}},{"before":"193eac9c042567b37334b869efb87bede2ddb069","after":"c8256e36e9d1ed7573e8e2f41290237334fd7bad","ref":"refs/heads/action-bar","pushedAt":"2024-07-27T18:47:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Enabled automatic navigation by default\n\nIf there's on onNavigationPress then automatically handle navigation. Don't need an autoNavigation prop at all. There could be multiple toolbars - toolbar and bottombar - and don't want them both having hamburgers if there's a drawer. So only allowed one auto drawer handler in scene view. But same could happen for back arrow - in that case can add an onNavigationPress handler to the bottom bar and it won't have the back arrow.\nThe one case think might need special prop is custom decorative nav icon on search bar on second scene and don't want back arrow (same for drawer). Can't add onNavigationPress because then not decorative anymore. Think this is super rare so can add prop if really needed later.\nTurning on by default is important because then users don't have to know about hamburger animation - they'll just get it if drawer and toolbar on same scene","shortMessageHtmlLink":"Enabled automatic navigation by default"}},{"before":"38401e0b09b702af3f116f236e51a2cbe9f8e4f4","after":"193eac9c042567b37334b869efb87bede2ddb069","ref":"refs/heads/action-bar","pushedAt":"2024-07-27T09:48:21.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Allowed custom navigation icon with auto\n\nImproved the idea. Want a user to always turn on autoNavigation without having to think about whether it's first screen or not. Allowing a custom navigation icon is crucial for that as well as firing onNavigationPress (if it's not been taken over by auto navigation).\nSo always going to set the navigation icon if it's provided. If it's not provided then going to use the default one from auto navigation (or from search bar if auto isn't on).","shortMessageHtmlLink":"Allowed custom navigation icon with auto"}},{"before":"426adcfb926055b18a655a60c9d1cbba7574f9fe","after":"38401e0b09b702af3f116f236e51a2cbe9f8e4f4","ref":"refs/heads/action-bar","pushedAt":"2024-07-21T20:34:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Added new line for consistency","shortMessageHtmlLink":"Added new line for consistency"}},{"before":"28233d101a0427c60ab1db4d4476cb0a07adb623","after":"426adcfb926055b18a655a60c9d1cbba7574f9fe","ref":"refs/heads/action-bar","pushedAt":"2024-07-21T16:11:12.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Removed warnings following android studio advice\n\nMain one was using pattern matching for instanceof","shortMessageHtmlLink":"Removed warnings following android studio advice"}},{"before":"08068826a249f6647d4c8571d5a280a4a85ef04c","after":"28233d101a0427c60ab1db4d4476cb0a07adb623","ref":"refs/heads/action-bar","pushedAt":"2024-07-21T15:40:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Added newline","shortMessageHtmlLink":"Added newline"}},{"before":"98f9799801539d63b664d8ad2c47259e8ab3ac8e","after":"08068826a249f6647d4c8571d5a280a4a85ef04c","ref":"refs/heads/action-bar","pushedAt":"2024-07-21T15:32:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Simplified now navigation icon always needed\n\nNeed it even if setting because might turn auto navigation back on without changing the navigation icon","shortMessageHtmlLink":"Simplified now navigation icon always needed"}},{"before":"76540c8e639ddd43c41ada81d18f928b8a899af6","after":"98f9799801539d63b664d8ad2c47259e8ab3ac8e","ref":"refs/heads/action-bar","pushedAt":"2024-07-20T20:27:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Renamed for clarity","shortMessageHtmlLink":"Renamed for clarity"}},{"before":"d3ff56b84eda453727a42e618b63b7afb6381633","after":"76540c8e639ddd43c41ada81d18f928b8a899af6","ref":"refs/heads/action-bar","pushedAt":"2024-07-20T14:14:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Restored icon when toggling autoNavigation\n\nOn drawer scenario had custom navigationIcon and autoNavigation off. Then toggled autoNavigation to on then back to off and then custom icon didn't appear. That's because it hadn't changed - so stored it even when autoNavigation off so can restore it later","shortMessageHtmlLink":"Restored icon when toggling autoNavigation"}},{"before":"2c4b7f35fdf02e189d9636f6edda9f0a759a3ab5","after":"d3ff56b84eda453727a42e618b63b7afb6381633","ref":"refs/heads/action-bar","pushedAt":"2024-07-20T14:09:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Allowed one of autoNavigation or navigation icon\n\nTurning on autoNavigation means let the Navigation router handle the navigation icon and navigation. Turning it off means user handles it. Keeps things simple - too complicated to allow autoNavigation with custom icon. Also clearer this way because there's only one navigation click listener which have to give to android when doing drawer toggle anyway.","shortMessageHtmlLink":"Allowed one of autoNavigation or navigation icon"}},{"before":"ddde4bca6627940026fb9b3133f13bb6b8444cef","after":"2c4b7f35fdf02e189d9636f6edda9f0a759a3ab5","ref":"refs/heads/action-bar","pushedAt":"2024-07-19T21:48:14.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Resync'ed when attached to window\n\nIf drawer opened/closed during the navigation then the arrow wasn't sync'ed when navigating back","shortMessageHtmlLink":"Resync'ed when attached to window"}},{"before":"c0fbf55a39ed68816d3cc3364ef26500302f3e3e","after":"ddde4bca6627940026fb9b3133f13bb6b8444cef","ref":"refs/heads/action-bar","pushedAt":"2024-07-16T16:46:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"grahammendick","name":"Graham Mendick","path":"/grahammendick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1761227?s=80&v=4"},"commit":{"message":"Removed code for old drawer\n\nI checked back and this seemed to be for handling activities - apparently drawer didn't open on second activity (https://github.com/grahammendick/navigation/pull/266). This seems to be a good time to remove this old code","shortMessageHtmlLink":"Removed code for old drawer"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEkMbKzwA","startCursor":null,"endCursor":null}},"title":"Activity ยท grahammendick/navigation"}