Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: filter by Relay nodeId #143

Open
RedShift1 opened this issue Dec 1, 2020 · 2 comments
Open

Feature request: filter by Relay nodeId #143

RedShift1 opened this issue Dec 1, 2020 · 2 comments

Comments

@RedShift1
Copy link

Right now filtering on primary and foreign keys work with the actual values from the database. This leaks an implementation detail and might be cumbersome to deal with if the datatype of this identifier changes in the future (for example from integer to uuid). If primary and foreign keys could be filtered by nodeId, this problem would be solved. Furthermore it would provide consistency with other methods that accept nodeId's.

@mattbretl
Copy link
Member

Could you expand on how you would want to filter on nodeId? Anything beyond equalTo/notEqualTo/in/notIn? I'm thinking anything outside of those wouldn't make sense for what's supposed to be an opaque identifier.

@RedShift1
Copy link
Author

RedShift1 commented Aug 2, 2021

That makes perfect sense to me, equal and in operations (and their not versions) should suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants