Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hono adaptor #2139

Open
benjie opened this issue Jul 26, 2024 · 5 comments
Open

Hono adaptor #2139

benjie opened this issue Jul 26, 2024 · 5 comments

Comments

@benjie
Copy link
Member

benjie commented Jul 26, 2024

https://github.com/litewarp/graphile-tools/blob/main/packages/hono-adapter/src/adapter.ts

@litewarp
Copy link

Hey! Saw you made this, so I'll ask questions here to keep things organized.

Question 1 - how important are the http major and minor versions? The Hono context object doesn't provide them like aws. I could wrap the server to extract it from the raw request but wasn't sure if it was worth the effort.

@benjie
Copy link
Member Author

benjie commented Aug 6, 2024

I don't think they're currently used for anything; but they could be in future - there are certain things that are different between HTTP/1.1 vs HTTP/2+, for example chunked transfer encoding is not supported in HTTP/2+.

@benjie benjie removed this from V5.0.0 Aug 6, 2024
@danzho
Copy link

danzho commented Aug 31, 2024

I've used Koa for idk, 10 years? Would love to migrate to Hono. 👍

@rfdrake27
Copy link

I've used Koa for idk, 10 years? Would love to migrate to Hono. 👍

As someone who recently switched from Express to Hono Bun I highly recommend it. It just feels like a leaner and streamlined version of Express. It has definitely sped up development for me.

@litewarp
Copy link

litewarp commented Oct 8, 2024

Just an update. Bun should work fine with the original adapter I made above, but there is no http2 or grpc support until bun adopts that natively. It looks like there's work being done, so I'll revisit once it's complete -- oven-sh/bun#14286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants