Fix Change type export (#2827)

* Fix Change type export

* prettier!!!

* fix export for DirectiveUsage

* export all missing meta functions

* fix test

Author: TuvalSimha

.changeset/odd-moons-sip.md

@@ -0,0 +1,6 @@
+---
+'@graphql-inspector/core': minor
+---
+
+Added missing types to Change type and fix typo "DirectiveUsageInputObjectdRemovedChange" to
+"DirectiveUsageInputObjectRemovedChange"

packages/core/__tests__/diff/directive-usage.test.ts

@@ -455,8 +455,10 @@ describe('directive-usage', () => {
 
       expect(changes.length).toEqual(1);
       expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
-      expect(change.type).toEqual('DIRECTIVE_USAGE_ARGUMENT_DEFINITION_ADDED');
-      expect(change.message).toEqual("Directive 'external' was added to argument 'a'");
+      expect(change.type).toEqual('DIRECTIVE_USAGE_INPUT_FIELD_DEFINITION_ADDED');
+      expect(change.message).toEqual(
+        "Directive 'external' was added to input field 'a' in input object 'Foo'",
+      );
     });
     test('removed directive', async () => {
       const a = buildSchema(/* GraphQL */ `
@@ -479,8 +481,10 @@ describe('directive-usage', () => {
 
       expect(changes.length).toEqual(1);
       expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
-      expect(change.type).toEqual('DIRECTIVE_USAGE_ARGUMENT_DEFINITION_REMOVED');
-      expect(change.message).toEqual("Directive 'external' was removed from input value 'Foo.a'");
+      expect(change.type).toEqual('DIRECTIVE_USAGE_INPUT_FIELD_DEFINITION_REMOVED');
+      expect(change.message).toEqual(
+        "Directive 'external' was removed from input field 'a' in input object 'Foo'",
+      );
     });
   });
 
@@ -634,7 +638,9 @@ describe('directive-usage', () => {
 
       expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
       expect(change.type).toEqual('DIRECTIVE_USAGE_ARGUMENT_DEFINITION_ADDED');
-      expect(change.message).toEqual("Directive 'external' was added to argument 'a'");
+      expect(change.message).toEqual(
+        "Directive 'external' was added to argument 'a' of field 'a' in type 'Foo'",
+      );
     });
 
     test('removed directive', async () => {
@@ -656,7 +662,9 @@ describe('directive-usage', () => {
 
       expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
       expect(change.type).toEqual('DIRECTIVE_USAGE_ARGUMENT_DEFINITION_REMOVED');
-      expect(change.message).toEqual("Directive 'external' was removed from argument 'Foo.a'");
+      expect(change.message).toEqual(
+        "Directive 'external' was removed from argument 'a' of field 'a' in type 'Foo'",
+      );
     });
   });
 
@@ -686,7 +694,7 @@ describe('directive-usage', () => {
 
       expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
       expect(change.type).toEqual('DIRECTIVE_USAGE_SCHEMA_ADDED');
-      expect(change.message).toEqual("Directive 'external' was added to schema");
+      expect(change.message).toEqual("Directive 'external' was added to schema 'Foo'");
     });
     test('removed directive', async () => {
       const a = buildSchema(/* GraphQL */ `
@@ -713,7 +721,7 @@ describe('directive-usage', () => {
 
       expect(change.criticality.level).toEqual(CriticalityLevel.Dangerous);
       expect(change.type).toEqual('DIRECTIVE_USAGE_SCHEMA_REMOVED');
-      expect(change.message).toEqual("Directive 'external' was removed from schema");
+      expect(change.message).toEqual("Directive 'external' was removed from schema 'Foo'");
     });
   });
 });

packages/core/src/diff/changes/change.ts

@@ -653,7 +653,7 @@ export type DirectiveUsageEnumValueRemovedChange = {
   };
 };
 
-export type DirectiveUsageInputObjectdRemovedChange = {
+export type DirectiveUsageInputObjectRemovedChange = {
   type: typeof ChangeType.DirectiveUsageInputObjectRemoved;
   meta: {
     inputObjectName: string;
@@ -812,6 +812,17 @@ export type DirectiveUsageInterfaceRemovedChange = {
     removedDirectiveName: string;
   };
 };
+
+export type DirectiveUsageArgumentDefinitionAddedChange = {
+  type: typeof ChangeType.DirectiveUsageArgumentDefinitionAdded;
+  meta: {
+    typeName: string;
+    fieldName: string;
+    argumentName: string;
+    addedDirectiveName: string;
+  };
+};
+
 type Changes = {
   [ChangeType.TypeAdded]: TypeAddedChange;
   [ChangeType.TypeRemoved]: TypeRemovedChange;
@@ -892,7 +903,7 @@ type Changes = {
   [ChangeType.DirectiveUsageEnumValueAdded]: DirectiveUsageEnumValueAddedChange;
   [ChangeType.DirectiveUsageEnumValueRemoved]: DirectiveUsageEnumValueRemovedChange;
   [ChangeType.DirectiveUsageInputObjectAdded]: DirectiveUsageInputObjectAddedChange;
-  [ChangeType.DirectiveUsageInputObjectRemoved]: DirectiveUsageInputObjectdRemovedChange;
+  [ChangeType.DirectiveUsageInputObjectRemoved]: DirectiveUsageInputObjectRemovedChange;
   [ChangeType.DirectiveUsageFieldAdded]: DirectiveUsageFieldAddedChange;
   [ChangeType.DirectiveUsageFieldRemoved]: DirectiveUsageFieldRemovedChange;
   [ChangeType.DirectiveUsageScalarAdded]: DirectiveUsageScalarAddedChange;
@@ -901,12 +912,14 @@ type Changes = {
   [ChangeType.DirectiveUsageObjectRemoved]: DirectiveUsageObjectRemovedChange;
   [ChangeType.DirectiveUsageInterfaceAdded]: DirectiveUsageInterfaceAddedChange;
   [ChangeType.DirectiveUsageInterfaceRemoved]: DirectiveUsageInterfaceRemovedChange;
-  [ChangeType.DirectiveUsageArgumentDefinitionAdded]: DirectiveUsageArgumentDefinitionChange;
+  [ChangeType.DirectiveUsageArgumentDefinitionAdded]: DirectiveUsageArgumentDefinitionAddedChange;
   [ChangeType.DirectiveUsageArgumentDefinitionRemoved]: DirectiveUsageArgumentDefinitionRemovedChange;
   [ChangeType.DirectiveUsageSchemaAdded]: DirectiveUsageSchemaAddedChange;
   [ChangeType.DirectiveUsageSchemaRemoved]: DirectiveUsageSchemaRemovedChange;
   [ChangeType.DirectiveUsageFieldDefinitionAdded]: DirectiveUsageFieldDefinitionAddedChange;
   [ChangeType.DirectiveUsageFieldDefinitionRemoved]: DirectiveUsageFieldDefinitionRemovedChange;
+  [ChangeType.DirectiveUsageInputFieldDefinitionAdded]: DirectiveUsageInputFieldDefinitionAddedChange;
+  [ChangeType.DirectiveUsageInputFieldDefinitionRemoved]: DirectiveUsageInputFieldDefinitionRemovedChange;
 };
 
 export type SerializableChange = Changes[keyof Changes];