Consistency; adjust schema operation type logic

Author: jdolle

packages/core/__tests__/diff/schema.test.ts

@@ -833,7 +833,7 @@ test('adding root type should not be breaking', async () => {
     [
       {
         "criticality": {
-          "level": "BREAKING",
+          "level": "NON_BREAKING",
         },
         "message": "Schema subscription root has changed from 'unknown' to 'Subscription'",
         "meta": {

packages/core/src/diff/changes/directive-usage.ts

@@ -895,7 +895,7 @@ function isOfKind<K extends keyof KindToPayload>(
   return kind === expectedKind;
 }
 
-export function directiveUsageArgumentAdded(args: DirectiveUsageArgumentAddedChange): Change {
+export function directiveUsageArgumentAddedFromMeta(args: DirectiveUsageArgumentAddedChange): Change {
   return {
     type: ChangeType.DirectiveUsageArgumentAdded,
     criticality: {
@@ -916,7 +916,7 @@ export function directiveUsageArgumentAdded(args: DirectiveUsageArgumentAddedCha
   };
 }
 
-export function directiveUsageArgumentRemoved(args: DirectiveUsageArgumentRemovedChange): Change {
+export function directiveUsageArgumentRemovedFromMeta(args: DirectiveUsageArgumentRemovedChange): Change {
   return {
     type: ChangeType.DirectiveUsageArgumentRemoved,
     criticality: {
@@ -949,7 +949,7 @@ export function directiveUsageChanged(
   compareLists(oldDirective?.arguments || [], newDirective.arguments || [], {
     onAdded(argument) {
       addChange(
-        directiveUsageArgumentAdded({
+        directiveUsageArgumentAddedFromMeta({
           type: ChangeType.DirectiveUsageArgumentAdded,
           meta: {
             addedArgumentName: argument.name.value,
@@ -966,7 +966,7 @@ export function directiveUsageChanged(
     },
 
     onMutual(argument) {
-      directiveUsageArgumentAdded({
+      directiveUsageArgumentAddedFromMeta({
         type: ChangeType.DirectiveUsageArgumentAdded,
         meta: {
           addedArgumentName: argument.newVersion.name.value,
@@ -984,7 +984,7 @@ export function directiveUsageChanged(
 
     onRemoved(argument) {
       addChange(
-        directiveUsageArgumentRemoved({
+        directiveUsageArgumentRemovedFromMeta({
           type: ChangeType.DirectiveUsageArgumentRemoved,
           meta: {
             removedArgumentName: argument.name.value,

packages/core/src/diff/changes/schema.ts

@@ -16,7 +16,7 @@ export function schemaQueryTypeChangedFromMeta(args: SchemaQueryTypeChangedChang
   return {
     type: ChangeType.SchemaQueryTypeChanged,
     criticality: {
-      level: CriticalityLevel.Breaking,
+      level: args.meta.oldQueryTypeName === 'unknown' ? CriticalityLevel.NonBreaking : CriticalityLevel.Breaking,
     },
     message: buildSchemaQueryTypeChangedMessage(args.meta),
     meta: args.meta,
@@ -49,7 +49,7 @@ export function schemaMutationTypeChangedFromMeta(args: SchemaMutationTypeChange
   return {
     type: ChangeType.SchemaMutationTypeChanged,
     criticality: {
-      level: CriticalityLevel.Breaking,
+      level: args.meta.oldMutationTypeName === 'unknown' ? CriticalityLevel.NonBreaking : CriticalityLevel.Breaking,
     },
     message: buildSchemaMutationTypeChangedMessage(args.meta),
     meta: args.meta,
@@ -82,7 +82,7 @@ export function schemaSubscriptionTypeChangedFromMeta(args: SchemaSubscriptionTy
   return {
     type: ChangeType.SchemaSubscriptionTypeChanged,
     criticality: {
-      level: CriticalityLevel.Breaking,
+      level: args.meta.oldSubscriptionTypeName === 'unknown' ? CriticalityLevel.NonBreaking : CriticalityLevel.Breaking,
     },
     message: buildSchemaSubscriptionTypeChangedMessage(args.meta),
     meta: args.meta,

packages/core/src/diff/input.ts

@@ -26,7 +26,7 @@ export function changesInInputObject(
 
   compareLists(Object.values(oldFields), Object.values(newFields), {
     onAdded(field) {
-      addChange(inputFieldAdded(newInput, field, oldInput === null));
+      addChange(inputFieldAdded(newInput, field, oldInput == null));
       changesInInputField(newInput, null, field, addChange);
     },
     onRemoved(field) {

packages/core/src/index.ts

@@ -56,6 +56,8 @@ export {
   directiveUsageSchemaRemovedFromMeta,
   directiveUsageUnionMemberAddedFromMeta,
   directiveUsageUnionMemberRemovedFromMeta,
+  directiveUsageArgumentRemovedFromMeta,
+  directiveUsageArgumentAddedFromMeta
 } from './diff/changes/directive-usage.js';
 export {
   directiveRemovedFromMeta,

packages/core/src/utils/compare.ts

@@ -78,13 +78,13 @@ export function compareLists<T extends { name: string | NameNode }>(
   const mutual: Array<{ newVersion: T; oldVersion: T }> = [];
 
   for (const oldItem of oldList) {
-    const newItem = newMap[extractName(oldItem.name)];
-    if (newItem === undefined) {
+    const newItem = newMap[extractName(oldItem.name)] ?? null;
+    if (newItem === null) {
       removed.push(oldItem);
     } else {
       mutual.push({
         newVersion: newItem,
-        oldVersion: oldItem,
+        oldVersion: oldItem ?? null,
       });
     }
   }

packages/patch/src/__tests__/fields.test.ts

@@ -45,6 +45,20 @@ describe('fields', () => {
     await expectPatchToMatch(before, after);
   });
 
+  test('fieldAdded to new type', async () => {
+    const before = /* GraphQL */ `
+      scalar Foo
+    `;
+    const after = /* GraphQL */ `
+      scalar Foo
+      type Product {
+        id: ID!
+        name: String
+      }
+    `;
+    await expectPatchToMatch(before, after);
+  });
+
   test('fieldArgumentAdded', async () => {
     const before = /* GraphQL */ `
       scalar ChatSession

packages/patch/src/__tests__/inputs.test.ts

@@ -16,6 +16,23 @@ describe('inputs', () => {
     await expectPatchToMatch(before, after);
   });
 
+  test('inputFieldAdded to new input', async () => {
+    const before = /* GraphQL */ `
+      scalar Foo
+    `;
+    const after = /* GraphQL */ `
+      scalar Foo
+      input FooInput {
+        id: ID!
+        other: String
+      }
+      type Query {
+        foo(foo: FooInput): Foo
+      }
+    `;
+    const changes = await expectPatchToMatch(before, after);
+  });
+
   test('inputFieldRemoved', async () => {
     const before = /* GraphQL */ `
       input FooInput {