Fix regression introduced in #2100 (#2129)

Fixes #2128

Author: kamilkisiela

CHANGELOG.md

@@ -2,10 +2,12 @@
 
 ### vNEXT
 
+- **core**: Fix regression [#2128](https://github.com/kamilkisiela/graphql-inspector/issues/2128) introduced in [#2100](https://github.com/kamilkisiela/graphql-inspector/pull/2100)
+
 ### v3.1.3
 
 - **core**: Fix missing export of `safeUnreachable` rule [#2063](https://github.com/kamilkisiela/graphql-inspector/issues/2063)
-- **core**: Fix equality for objects  [#2100](https://github.com/kamilkisiela/graphql-inspector/pull/2100)
+- **core**: Fix equality for objects [#2100](https://github.com/kamilkisiela/graphql-inspector/pull/2100)
 
 ### v3.1.2
 

README.md

@@ -10,9 +10,9 @@
 It helps you validate documents and fragments against a schema and even find similar or duplicated types.
 
 > You may like [GraphQL Hive](https://graphql-hive.com) as well!
-> 
+>
 > It's an open-source performance monitoring tool and schema registry for GraphQL.
-> 
+>
 > GraphQL Hive is currently available as a hosted service but it offers self-hosting as well.
 
 Use GraphQL Inspector however you want:

action.yml

@@ -36,7 +36,7 @@ inputs:
     description: |
       Merge Pull Request's branch with the target branch to get the schema.
       Helps to get the correct state of schema when Pull Request is behind the target branch
-      
+
       (enabled by default)
 outputs:
   changes:

action/index.js

@@ -67,7 +67,6 @@
     "@sentry/tracing": "6.10.0",
     "husky": "4.3.8",
     "immer": "9.0.6",
-    "lerna": "4.0.0",
     "probot": "11.3.0",
     "shelljs": "0.8.5"
   },

lerna.json

@@ -7,6 +7,10 @@ test('isEqual', () => {
   expect(isEqual(1, 1)).toBe(true);
   expect(isEqual(1, 1.0)).toBe(true);
 
+  expect(isEqual(undefined, 1)).toBe(false);
+  expect(isEqual(null, 1)).toBe(false);
+  expect(isEqual(null, null)).toBe(true);
+
   expect(isEqual(['a'], ['a'])).toBe(true);
   expect(isEqual(['a'], ['A'])).toBe(false);
   expect(isEqual(['a'], [''])).toBe(false);

package.json

@@ -21,11 +21,15 @@ test('undefined', () => {
 
 test('object', () => {
   expect(safeString({})).toBe('{}');
-  expect(safeString(Object.create(null, { foo: { value: 42, enumerable: true } }))).toBe('{ foo: 42 }');
+  expect(
+    safeString(Object.create(null, { foo: { value: 42, enumerable: true } })),
+  ).toBe('{ foo: 42 }');
 });
 
 test('array', () => {
   expect(safeString(['42', '42'])).toBe("[ '42', '42' ]");
   expect(safeString([{}])).toBe('[ {} ]');
-  expect(safeString([Object.create(null, { foo: { value: 42, enumerable: true } })])).toBe('[ { foo: 42 } ]');
+  expect(
+    safeString([Object.create(null, { foo: { value: 42, enumerable: true } })]),
+  ).toBe('[ { foo: 42 } ]');
 });

packages/core/__tests__/utils/compare.ts

@@ -21,7 +21,7 @@ export function isEqual<T>(a: T, b: T): boolean {
     return true;
   }
 
-  if (typeof a === 'object' && typeof b === 'object') {
+  if (a && b && typeof a === 'object' && typeof b === 'object') {
     const aRecord = a as Record<string, unknown>;
     const bRecord = b as Record<string, unknown>;
 
@@ -35,8 +35,8 @@ export function isEqual<T>(a: T, b: T): boolean {
         return false;
       }
     }
-    
-    return true
+
+    return true;
   }
 
   return a === b || (!a && !b);

packages/core/__tests__/utils/string.ts

@@ -12,19 +12,19 @@ GraphQL Inspector accepts CommonJS and ESModules
 
 ```js
 // Example for loading and merging multiple .graphql files into a single schema
-const { makeExecutableSchema } = require("@graphql-tools/schema");
-const { loadFilesSync } = require('@graphql-tools/load-files');
+const { makeExecutableSchema } = require('@graphql-tools/schema')
+const { loadFilesSync } = require('@graphql-tools/load-files')
 
-const typeDefs = loadFilesSync('**/*.graphql');
+const typeDefs = loadFilesSync('**/*.graphql')
 
 module.exports = makeExecutableSchema({ typeDefs })
 ```
 
 **ESM default export**
 
 ```ts
-import { makeExecutableSchema } from "@graphql-tools/schema";
-import { typeDefs } from "./type-defs";
+import { makeExecutableSchema } from '@graphql-tools/schema'
+import { typeDefs } from './type-defs'
 
 // as `default`
 export default makeExecutableSchema({ typeDefs })
@@ -33,8 +33,8 @@ export default makeExecutableSchema({ typeDefs })
 **ESM named export**
 
 ```ts
-import { makeExecutableSchema } from "@graphql-tools/schema";
-import { typeDefs } from "./type-defs";
+import { makeExecutableSchema } from '@graphql-tools/schema'
+import { typeDefs } from './type-defs'
 
 // as `schema` variables
 export const schema = makeExecutableSchema({ typeDefs })