Fix tests that followed old argument validation behavior

Add regression coverage to ensure fields without declared arguments reject unknown arguments.

Author: zohnannor

juniper/src/tests/query_tests.rs

@@ -1,5 +1,6 @@
 use crate::{
-    graphql,
+    GraphQLError, RuleError, graphql,
+    parser::SourcePosition,
     schema::model::RootNode,
     tests::fixtures::starwars::schema::{Database, Query},
     types::scalars::{EmptyMutation, EmptySubscription},
@@ -290,6 +291,26 @@ async fn test_query_name_invalid_variable() {
     );
 }
 
+#[tokio::test]
+async fn test_rejects_unknown_argument_on_query_field_without_args() {
+    let doc = "{ hero { name(unknownArg: true) } }";
+    let database = Database::new();
+    let schema = RootNode::new(
+        Query,
+        EmptyMutation::<Database>::new(),
+        EmptySubscription::<Database>::new(),
+    );
+
+    assert_eq!(
+        crate::execute(doc, None, &schema, &graphql::vars! {}, &database).await,
+        Err(GraphQLError::ValidationError(vec![RuleError::new(
+            r#"Unknown argument "unknownArg" on field "name" of type "Character""#,
+            &[SourcePosition::new(14, 0, 14)],
+        )])),
+        "expected validation error, got successful response",
+    );
+}
+
 #[tokio::test]
 async fn test_query_friends_names() {
     let doc = r#"{ human(id: "1000") { friends { name } } }"#;

juniper/src/tests/subscriptions.rs

@@ -148,7 +148,7 @@ fn create_and_execute(
 #[test]
 fn returns_requested_object() {
     let query = r#"subscription {
-        asyncHuman(id: "1") {
+        asyncHuman {
             id
             name
         }
@@ -176,7 +176,7 @@ fn returns_requested_object() {
 #[test]
 fn returns_error() {
     let query = r#"subscription {
-        errorHuman(id: "1") {
+        errorHuman {
             id
             name
         }
@@ -227,7 +227,7 @@ fn can_access_context() {
 fn resolves_typed_inline_fragments() {
     let query = r#"subscription {
              ... on MySubscription {
-                asyncHuman(id: "32") {
+                asyncHuman {
                   id
                 }
              }
@@ -255,7 +255,7 @@ fn resolves_typed_inline_fragments() {
 fn resolves_nontyped_inline_fragments() {
     let query = r#"subscription {
              ... {
-                asyncHuman(id: "32") {
+                asyncHuman {
                   id
                 }
              }
@@ -310,7 +310,7 @@ fn can_access_arguments() {
 #[test]
 fn type_alias() {
     let query = r#"subscription {
-        aliasedHuman: asyncHuman(id: "1") {
+        aliasedHuman: asyncHuman {
             id
             name
         }