Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2022-11] if a field is deprecated on a type, it must be deprecated on the interface #1331

Closed
benjie opened this issue Jul 8, 2023 · 6 comments
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Jul 8, 2023

Does this rule already exist? Should it?

Matt: do we have the rule that if a field is deprecated on a type then it must also be deprecated on any interface?
Lee: good question
Ivan: no, we don't have this rule.
Stephen: sounds like another PR; it probably should - right?
Lee: yeah, it's surprising that hasn't come up in the Facebook API.
Matt: interface fields tend to be Hack/PHP; everyone gets the same implementation (same code executed) - deprecating it deprecates it everywhere.
ACTION - validate this.


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie
Copy link
Member Author

benjie commented Jul 8, 2023

Finally catching up with filing action items...

@mjmahone @fotoetienne Would either of you like to take this on?

@benjie
Copy link
Member Author

benjie commented Nov 9, 2023

Spec PR raised here: graphql/graphql-spec#1053

@benjie
Copy link
Member Author

benjie commented Nov 9, 2023

GraphQL.js PR raised here: graphql/graphql-js#3986

@benjie
Copy link
Member Author

benjie commented Nov 9, 2023

Added to next WG: #1429

@benjie benjie added Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. and removed stale labels Nov 9, 2023
@fotoetienne
Copy link
Contributor

Amazing, thanks for doing this @benjie

@benjie benjie self-assigned this Nov 16, 2023
@benjie
Copy link
Member Author

benjie commented Dec 7, 2023

PRs raised; closing 👍

@benjie benjie closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Development

No branches or pull requests

2 participants