You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
type Mutation {
updateNote(input: MutateNoteInput!, where: UpdateNoteFilter): Note!
}
We have been using filter in GraphQL CRUD Java and encountered this conflict, where and filter function the same. where sounds more SQL specific, can be replaced with filter in GraphQL CRUD spec.
IMO, a delete should not require an input argument name, it should be filter.
type Mutation {
deleteNote(input: MutateNoteInput!): Note
}
Suggested type defination:
type Mutation {
deleteNote(filter: UpdateNoteFilter!): Note
}
Makes sense to me also, input makes more sense when inserting data. I guess it was used because it is a mutation.
It would be great if you could copy this issue to https://github.com/graphqlcrud/spec, where it can be discussed in a wider context as there are other contributors who may be interested in this discussion.
It would be great if you could copy this issue to https://github.com/graphqlcrud/spec, where it can be discussed in a wider context as there are other contributors who may be interested in this discussion.
We have been using
filter
in GraphQL CRUD Java and encountered this conflict,where
andfilter
function the same.where
sounds more SQL specific, can be replaced withfilter
in GraphQL CRUD spec.IMO, a
delete
should not require aninput
argument name, it should befilter
.Suggested type defination:
cc: @wtrocki @machi1990 @rareddy
The text was updated successfully, but these errors were encountered: