Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local: deleting files from container ignores container path #210

Open
urisimchoni opened this issue Jun 24, 2019 · 0 comments · May be fixed by #211
Open

local: deleting files from container ignores container path #210

urisimchoni opened this issue Jun 24, 2019 · 0 comments · May be fixed by #211

Comments

@urisimchoni
Copy link
Contributor

This is like #170 but for deletion. c.RemoveItem() accepts a string. For cloud backends, this string is relative to the container. For local, it is an absolute path.

To delete an item based on it's known path in the container, currently the only portable thing to do would be to create an Item, and then delete this item's ID(). However this is both cumbersome an costly for cloud backends which don't require the extra Item() call.

It would be nice to support delete-by-relative-path in the local backend, which would mean deleting relative to container path.
urisimchoni added a commit to urisimchoni/stow that referenced this issue Jun 24, 2019
@urisimchoni
tests: test deletion by name
90a2423 
This tests issue WasabiAiR#210 - without the local-FS fix, it passes on
cloud file systems and fails on local, with the fix it also passes
on local.
@urisimchoni urisimchoni linked a pull request Jun 24, 2019 that will close this issue
Open
urisimchoni added a commit to urisimchoni/stow that referenced this issue Apr 30, 2020
@urisimchoni
tests: test deletion by name
c35e8dd 
This tests issue WasabiAiR#210 - without the local-FS fix, it passes on
cloud file systems and fails on local, with the fix it also passes
on local.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

local: Fix remove by container-relative path urisimchoni/stow
1 participant
@urisimchoni