Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local: Fix remove by container-relative path #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

local: Fix remove by container-relative path #211

wants to merge 2 commits into from

Conversation

urisimchoni
Copy link
Contributor

This fixes #210, and allows applications to delete an item with the same path that's been used to create it in the container.

@urisimchoni
Copy link
Contributor Author

Ping....

@AlexAkulov
Copy link

Is this project alive?

@urisimchoni
LOCAL: on deletion, interpret relative paths as container-based
978547e 
If the path to delete is a file-system relative path, interpret it
as relative to the container, not the current directory.
@urisimchoni
tests: test deletion by name
c35e8dd 
This tests issue WasabiAiR#210 - without the local-FS fix, it passes on
cloud file systems and fails on local, with the fix it also passes
on local.
@urisimchoni
Copy link
Contributor Author

rebased on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local: deleting files from container ignores container path
2 participants
@urisimchoni @AlexAkulov