local: only walk the subdirectory designated by prefix #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When listing items using the local-file-system driver, only traverse the subdirectory with longest prefix that contains the given listing prefix. Three cases are of interest: a. The listing prefix is foo/bar/ - we walk subdirectory foo/bar under the container's path. b. The listing prefix is foo/ba - we walk subdirectory foo under the container's path, and filter stuff that doesn't begin with foo/ba. c. The prefix is an empty string - walk the container's path like today.
|
rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #140.
When listing items using the local-file-system driver, only
traverse the subdirectory with longest prefix that contains
the given listing prefix.
Three cases are of interest:
a. The listing prefix is foo/bar/ - we walk subdirectory
foo/barunder the container's path.
b. The listing prefix is foo/ba - we walk subdirectory
foounderthe container's path, and filter stuff that doesn't begin with
foo/ba.c. The prefix is an empty string - walk the container's path like
today.
There's a rather aged PR for this issue - #149. However that PR has some issues - it uses path instead of filepath when filepath is required, and it doesn't take into account case c above. Because it's rather old, I opted to proposing another fix instead of commenting on the exising PR.