Support container.Put without knowing the item size #214
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any updates here ? |
When putting an item, the item's data is retrieved from an io.Reader, but a size argument is also supplied. This change causes the local backend to ignore the size (as what most other backends do) if it's negative. This allows for data sources whose size is not known in advance (e.g. getting an HTTP upload request with a multipart/form-data payload).
Show that all backends can receive -1 as size for Put.
|
rebased on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing -1 as item size, which means we don't know the item's size.
Most storage backends don't really care about the size parameter. This PR modifies the local backend to also don't care in case of -1, and adds a test to codify this behavior.
One use case for this is receiving HTTP upload requests (with multipart/form-data payload) and streaming them to a storage server without having to store the entire file in the HTTP server.