not writing image for fixnan test - looks like the resulting image is not always identical so the test keeps failing

grdanny · grdanny · commit 03c4b0ef0192 · 2024-09-27T15:14:22.000-07:00
Signed-off-by: Daniel Greenstein &lt;danny.gr@gmail.com&gt;
diff --git a/testsuite/docs-examples-cpp/ref/out.txt b/testsuite/docs-examples-cpp/ref/out.txt
@@ -111,8 +111,6 @@ cshift.exr           :  256 x  256, 4 channel, half openexr
     SHA-1: 000F95FDC44D4DBDA8B4041C2506149C7AE28ACA
 texture.exr          :  256 x  256, 3 channel, half openexr (+mipmap)
     SHA-1: 4074B050432CE7C664CEC4546A46E74F9A310CDC
-with_nans_fixed.tif  :  256 x  256, 3 channel, float tiff
-    SHA-1: FE830FB041FAE5F1AA16B23FB69B91DED4BF5B73
 checker_with_alpha_filled.exr :  256 x  256, 4 channel, half openexr
     SHA-1: B245E027638D5C1BA2608FEDDB3BB9B5E9FA3A44
 tahoe_median_filter.tif :  512 x  384, 3 channel, uint8 tiff
diff --git a/testsuite/docs-examples-cpp/run.py b/testsuite/docs-examples-cpp/run.py
@@ -71,7 +71,6 @@
     "reorient.exr",
     "cshift.exr",
     "texture.exr",
-    "with_nans_fixed.tif",
     "checker_with_alpha_filled.exr",
     "tahoe_median_filter.tif",
     "tahoe_unsharp_mask.tif"
diff --git a/testsuite/docs-examples-cpp/src/docs-examples-imagebufalgo.cpp b/testsuite/docs-examples-cpp/src/docs-examples-imagebufalgo.cpp
@@ -514,7 +514,9 @@ void example_fixNonFinite()
                             &pixelsFixed);
     std::cout << "Repaired " << pixelsFixed << " non-finite pixels\n";
     // END-imagebufalgo-fixNonFinite
-    Src.write("with_nans_fixed.tif");
+
+    // fixing the nans seems nondeterministic - so not writing out the image
+    // Src.write("with_nans_fixed.tif");
 
 }
 
diff --git a/testsuite/docs-examples-python/ref/out.txt b/testsuite/docs-examples-python/ref/out.txt
@@ -111,8 +111,6 @@ cshift.exr           :  256 x  256, 4 channel, half openexr
     SHA-1: 000F95FDC44D4DBDA8B4041C2506149C7AE28ACA
 texture.exr          :  256 x  256, 3 channel, half openexr (+mipmap)
     SHA-1: 4074B050432CE7C664CEC4546A46E74F9A310CDC
-with_nans_fixed.tif  :  256 x  256, 3 channel, float tiff
-    SHA-1: FE830FB041FAE5F1AA16B23FB69B91DED4BF5B73
 checker_with_alpha_filled.exr :  256 x  256, 4 channel, half openexr
     SHA-1: B245E027638D5C1BA2608FEDDB3BB9B5E9FA3A44
 tahoe_median_filter.tif :  512 x  384, 3 channel, uint8 tiff
diff --git a/testsuite/docs-examples-python/run.py b/testsuite/docs-examples-python/run.py
@@ -67,7 +67,6 @@
     "reorient.exr",
     "cshift.exr",
     "texture.exr",
-    "with_nans_fixed.tif",
     "checker_with_alpha_filled.exr",
     "tahoe_median_filter.tif",
     "tahoe_unsharp_mask.tif"
diff --git a/testsuite/docs-examples-python/src/docs-examples-imagebufalgo.py b/testsuite/docs-examples-python/src/docs-examples-imagebufalgo.py
@@ -451,9 +451,10 @@ def example_fixNonFinite():
     # BEGIN-imagebufalgo-fixNonFinite
     Src = ImageBuf("with_nans.tif")
     ImageBufAlgo.fixNonFinite (Src, Src, oiio.NONFINITE_BOX3)
-    Src.write("with_nans_fixed.tif")
     # END-imagebufalgo-fixNonFinite
 
+    # fixing the nans seems nondeterministic - so not writing out the image
+    # Src.write("with_nans_fixed.tif")
 
 def example_fillholes_pushpull():
     print("example_fillholes_pushpull")

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,9 @@ void example_fixNonFinite()`
`514`	`514`	`&pixelsFixed);`
`515`	`515`	`std::cout << "Repaired " << pixelsFixed << " non-finite pixels\n";`
`516`	`516`	`// END-imagebufalgo-fixNonFinite`
`517`		`- Src.write("with_nans_fixed.tif");`
	`517`	`+`
	`518`	`+ // fixing the nans seems nondeterministic - so not writing out the image`
	`519`	`+ // Src.write("with_nans_fixed.tif");`
`518`	`520`
`519`	`521`	`}`
`520`	`522`