Skip to content

Latest commit

 

History

History
190 lines (149 loc) · 8.39 KB

CONTRIBUTING.md

File metadata and controls

190 lines (149 loc) · 8.39 KB
Raw

Contributing

We are super happy if you are interested in contributing to the Green Metrics Tool.

All contributions should be done via Pull Requests.

Please see our: Contribution Guidelines

Python conventions

We adhere to standard (PEP8) python conventions for the most part. Here we address a few grey areas and stylistic choices.

  • quotes

    • use ' for fixed constant strings
    • use " for modifiable and format strings
    • break this rule if needed to avoid escaping
      • e.g., re.compile(r'say "hi"')

  • multiline component imports should be in parens, one component per line, alphabetical

    from foo import (
	bar,
	bazzle,
	otherstuff,
)

  • try to put class-specific constants inside class

    • e.g., Membership.MEMBER_TYPE_PATIENT

  • same for class-specific exceptions

    • e.g., MetricDefinition.MetricMissingData

  • use foo.pk is None instead of foo._state.adding to test for insertion in pre-save hooks

    • this is not totally obvious in public convention, but we decided we don't like accessing vars that start with _ if we can help it
    • avoid use of # pylint: disable=protected-access

  • add tests for any use of variables which start with _

    • whenever we access a variable like django's model._meta, we should make sure we write a test case which covers the particular use case so that we are informed of any behavior changes

Lint

We use pylint to check for clean code, with a few minor variations:

  • Because of the way we handle a lot of imports we need to modify the sys.path to include some folders. This can not be understood by the linter so most of the import checks will not work and need disabling.

  • We have also disabled most of the requirements for docstrings as they often tend to state the obvious.

  • pylint has quite good code duplication finding capabilities which trigger a lot of our code which actually has a lot of duplicate code as for example the provider.py just sets a few things and then relies on the BaseProvider to do most of the heavy lifting. We could refactor this but this would lead to very unreadable code in the greater context of things.

To check if your code works you can call pylint -j0 **.py in the project directory.

We recommend that you set a pre-commit hook to lint your code every time you commit. This can be done by adding

git diff --diff-filter=d --cached --name-only | grep -E -i '.py$' | xargs -r pylint -j0

to a file named ./.git/hooks/pre-commit and making it executable chmod +x ./.git/hooks/pre-commit

Because of the automatic checks, it is tempting to use the # pylint: disable directive. Some guidelines on when to use or avoid this directive follow:

  • instead of disabling unused-argument, prefix the arg (or kwarg) with _

  • if you do add disable directives, be aware of where you place them. They can unintentially effect more code than you indend. The order of precidence should be:

    1. inline (only affects the current line)
    2. wrap small bits of code in # pylint: disable ... # pylint: enable blocks
    3. scope to method calls by placing within the method
    4. scope to class defs by placing within the class definition
    5. last resort: scope to module

Git Branching Strategy

Branch naming conventions:

  • Use <desc>-<issue number> for feature/topic branches
  • Use wip- as a prefix for branches are not stable and should not be branched off
  • Prefer hyphens to underscores and lowercase branch names
    • csv-reports-142 not CSV_Reports_142

Merging with dev:

  1. File an issue if one does not exist already
  2. Create a branch of the form <desc>-<issue number>
  3. Make sure your branch is up to date, then push to GitHub
  4. Create a pull request against dev
  5. Assign reviewers
  6. Add commits to address feedback
  7. Squash commits, as appropriate
  8. Merge with dev
  9. Delete your branch on GitHub

An example of this flow would be:

  1. Alice files issue #456 to build a CSV Reporting module
  2. She creates the branch csv-reports-456 with her commits
  3. She opens a pull request against dev with her branch
  4. She assigns Bob to review it
  5. Bob leaves feedback for Alice to address
  6. Alice pushes additional commits to address the feedback
  7. Bob gives it a thumbsup and Alice squashes some commits
  8. Alice merges the pull request with dev
  9. Alice deletes branch csv-reports-456

In general, do not push directly to a branch unless you are the owner or have previously discussed it with the branch owner.

To update someone else's branch:

  1. Create <branch name>-pr-<author>
  2. Add commits and create a PR against the original branch
  3. Add the branch owner as a reviewer
  4. Address feedback from the owner
  5. The owner merges the branch when satisfied
  6. Delete your branch

An example of this flow would be:

  1. Given Alice's branch csv-reports-456, Bob creates csv-reports-456-pr-bob
  2. Bob adds commits and opens a PR against Alice's branch
  3. Bob adds Alice as a reviewer
  4. Alice leaves feedback for Bob, which Bob addresses
  5. Alice merges Bob's pull request
  6. Bob deletes branch csv-reports-456-pr-bob

Git Commit Messages

  • Use the present tense in the subject
    • "Add feature" not "Added feature"
  • Use the imperative mood in the subject
    • "Move cursor to..." not "Moves cursor to..."
  • Leave a blank line between the subject and the body
  • Limit the subject to 50 characters or less
  • Limit the body to 72 columns or less (configure your editor to enforce this)
  • Reference issues and pull requests liberally in the description
  • When only changing documentation, include [ci skip] in the commit description
  • Include syntax to automatically close issues
  • Squash commits to the extent that it improves clarity
    • but don't combine patches for two issues in one commit

Rationale behind this is here, here, here, here, and here. For a contrarian view, see here.

Optional - consider starting the commit subject with an applicable emoji:

emoji shorthand usage
🎨 :art: Cosmetic/style changes
🐎 :racehorse: Performance
♻️ :recycle: Refactoring
✨ :sparkles: New feature
📚 :books: Documentation
📇 :card_index: Metadata/fixtures
🔧 :wrench: Tooling
💾 :floppy_disk: Data migration
🗑️ :wastebasket: Remove code/files
🐛 :bug: Bug fix
🔥 :fire: Hotfix
💩 :poop: Deprecation
💚 :green_heart: Fixing the CI build
✅ :white_check_mark: Adding tests
🔒 :lock: Dealing with security
👕 :shirt: Removing linter warnings
⬆️ :arrow_up: Upgrading dependencies
⬇️ :arrow_down: Downgrading dependencies
🐧 :penguin: Fixing something on Linux
🍎 :apple: Fixing something on macOS
🏁 :checkered_flag: Fixing something on Windows
🚱 :non-potable_water: Fix memory leaks