travis-ci crontab check

[MarvinT]

Is the crontab check necessary?

My understanding is that it acts to make sure the script only runs when the crontab triggers it, i.e. excluding runs after commits.

However, since the code is(?) robust to running multiple times, this seems to only stymie initial setup attempts.

I can submit a pr to address this if its ok to remove it

[dhimmel]

Here is the code in question:

scrumlord/.travis.yml

Lines 13 to 15 in 9d43aa3

	after_success:
	- test $TRAVIS_EVENT_TYPE = "cron" &&
	python upkeep.py --workdays-ahead=1 --token=$GH_TOKEN

I think the $TRAVIS_EVENT_TYPE = "cron" logic is also preventing attempted upkeep after_success on pull requests.

However, since the code is(?) robust to running multiple times, this seems to only stymie initial setup attempts.

It should be. However, users can get used to the scheduled jobs occurring at roughly the same time every day. I don't have a strong opinion on whether non-cron commits to master should trigger upkeep, so @MarvinT if the current design is a problem for you, we could change it.

[MarvinT]

I've solved it by just creating an extra branch

Maybe I can just add that as a note in deployment instructions.