Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't cancel an external item from being dragged by pressing 'Esc' key #2695

Open
adrianbenjuya opened this issue Jun 6, 2024 · 2 comments

Comments

@adrianbenjuya
Copy link

adrianbenjuya commented Jun 6, 2024

Subject of the issue

As a user I want to cancel Drag&Drop of a new item from outside the grid by pressing 'Esc' key while the item is being dragged. This works fine for items that are already inside the grid.

Your environment

  • Gridstack demo page
  • Google Chrome

Steps to reproduce

Just drag an external item and press 'Esc' key while dragging

chrome_CTznjhRBKu

Expected behavior

Dragging action should be cancelled, or if not possible at least handle the error.

@adumesny
Copy link
Member

adumesny commented Jun 6, 2024

I added 'Esc' key as an addition to a user paying for the 'r' feature, but I'm not planning to add more options to it (like dragging from outside, which ideally would work too) unless someone wants to donate for it.

@adrianbenjuya
Copy link
Author

adrianbenjuya commented Jun 13, 2024

I created a PR where I prevent throwing the error when n.grid is undefined, you can check it out

#2698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants