Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to change HEADER_CHUNK_DIVISION #131

Open
jonhallur opened this issue Feb 8, 2024 · 1 comment
Open

No way to change HEADER_CHUNK_DIVISION #131

jonhallur opened this issue Feb 8, 2024 · 1 comment

Comments

@jonhallur
Copy link

The writer is using 128 for ticks per quarter note. The old midi standard was 48 (twice that of the old SMPTE 24 pulses per quarter note) and many later programs started using 96. Many modern sequencers are using either 480 or 960.

Looked at the code, and seeing how the HEADER_CHUNK_DIVISION is used to convert note durations to ticks in static function, I can think of no good way to change this with the current architecture.

@grimmdude
Copy link
Owner

Hi @jonhallur, yea the HEADER_CHUNK_DIVISION value is currently defined as a constant without a way to change it programmatically. Sounds like it would be useful to add a method to change this during runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants