Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't transform Fn::Sub: to !<!Sub> #7

Open
S-Cardenas opened this issue Jul 18, 2019 · 2 comments
Open

Please don't transform Fn::Sub: to !<!Sub> #7

S-Cardenas opened this issue Jul 18, 2019 · 2 comments

Comments

@S-Cardenas
Copy link

We should be allowed to specify whether we want to output the fully written out version of !<!Sub> or the Fn::Sub version of it. The reason is that the short notation version of this, !Sub, fails when used with Transform::Include. See this example.

@johnbeech
Copy link

👍 ( + 1 ) this has really wrecked the readability of our Yaml files... have been trying to dynamically add properties / tags to the document tree, buy yamlDump just creates crazy output that doesn't look good when raising PRs across multiple (20+ repos).

@dsagal
Copy link
Member

dsagal commented Sep 29, 2020

No objection, but I don't have the bandwidth to work on it. If the underlying js-yaml supports it, I imagine it would be straightforward; if not, then it might not be worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants