Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM build failing if combining --vmefi with --arch arm64 #257

Open
adrelanos opened this issue Dec 8, 2023 · 0 comments
Open

VM build failing if combining --vmefi with --arch arm64 #257

adrelanos opened this issue Dec 8, 2023 · 0 comments

Comments

@adrelanos
Copy link
Contributor

adrelanos commented Dec 8, 2023

From a user perspective it is valid to combine --vmefi with --arch arm64.

+ mkfs.fat -n EFI /dev/mapper/loop0p1
mkfs.fat 4.2 (2021-01-31)
+ MKFS_OPTS=' -F -L LINUX'
+ einfo 'Running mkfs.ext4  -F -L LINUX on /dev/mapper/loop0p3p3'
+ einfon 'Running mkfs.ext4  -F -L LINUX on /dev/mapper/loop0p3p3\n'
+ '[' '' '!=' yes ']'
+ '[' einfon = ebegin ']'
+ printf ' %s*%s Running mkfs.ext4  -F -L LINUX on /dev/mapper/loop0p3p3\n' 'e[32;01m' 'e[0m'
 e[32;01m*e[0m Running mkfs.ext4  -F -L LINUX on /dev/mapper/loop0p3p3
+ LAST_E_CMD=einfon
+ return 0
+ return 0
+ mkfs.ext4 -F -L LINUX /dev/mapper/loop0p3p3
mke2fs 1.47.0 (5-Feb-2023)
The file /dev/mapper/loop0p3p3 does not exist and no size was specified.

In that case an unexpected code path will be used. if is if [ -n "$VMEFI" ]; then which means that code path will be used instead of the if [ "$ARCH" = 'arm64' ]; then code path.

It's awesome that grml-debootstrap recently learned VMEFI and ARM64 support. Now we can iterate based on that.

I don't think this should be solved on the command line parsing level, i.e. unset VMEFI if using --arch amd64? Seems better to refactor, simplify all the related code. But that seems a different request than fixing this. Therefore created a separate issue for that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants