Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcardconfig: configuring interfaces immediately brings them down/offline before configuration finished #8

Open
jkirk opened this issue Apr 1, 2020 · 3 comments
Open

netcardconfig: configuring interfaces immediately brings them down/offline before configuration finished #8

jkirk opened this issue Apr 1, 2020 · 3 comments

Comments

@jkirk
Copy link
Contributor

jkirk commented Apr 1, 2020

When starting netcardconfig (either after selecting it in grml-network or directly) the system is set offline before the configuration is completed.

netcardconfig should only touch and change the network configuration after the user has committed a change.
jkirk added a commit to jkirk/grml-network that referenced this issue Apr 2, 2020
@jkirk
netcardconfig: Run ifdown immediately before configuring the network …
aa17a3a 
…device

When running netcardconfig is set offline before the configuration is
completed. The network configuration should only be touched after
everything is set.

While at it also removed the sleep phase. The network interface should
be release and down fine after the ifdown is completed.

Closes: grml#8
jkirk added a commit to jkirk/grml-network that referenced this issue Apr 2, 2020
@jkirk
netcardconfig: Run ifdown immediately before configuring the network …
7f85c93 
…device

When running netcardconfig the network device is set offline before the
configuration is completed. The network configuration should only be
touched after everything is set.

While at it also removed the sleep phase. The network interface should
be released and down fine after ifdown is completed.

Closes: grml#8
@jkirk jkirk mentioned this issue Apr 2, 2020
Closed
@jkirk
Copy link
Contributor Author

jkirk commented Apr 9, 2020

PR #10 did not solve the problem correctly. An alternative approach was proposed. This requires quite some refactoring of the code though but it seems worth it. @mika What do you think?

@mika
Copy link
Member

mika commented Jun 23, 2020

@jkirk I think the suggestion to use /etc/network/interfaces.new makes sense. Also a refactoring of the code would be good anyway, I would also like to suggest getting rid of the more advanced WiFi configuration options like iwpriv and iwspy that I think no one really uses and everyone(?) just skips. :)

@mika mika changed the title netcardconfig immediately goes offline netcardconfig: configuring interfaces immediately brings them down/offline before configuration finished Jul 18, 2020
@mika
Copy link
Member

mika commented Jul 18, 2020

FTR, I adjusted the issue name, since it was unclear (I even thought this issue is no longer present and it took me a while until I noticed what you mean :))

@mika mika mentioned this issue Jul 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

netcardconfig: Run ifdown immediately before configuring the network … jkirk/grml-network
2 participants
@mika @jkirk