Discrepancy in location totals in API based on archived status

[snipe]

This isn't so much of a duplicate of #13752 but more of a re-statement of the issue.

A few things I noticed when looking at the locations index vs the locations detail. First, the locations API endpoint does't take the ->AssetsForShow() scope into consideration, which is why the number don't match.

With "Show archived in lists", the numbers don't agree, but with it unchecked, they do agree, meaning the count on the tabs is correct, the API response isn't being scoped properly.

The tabs do use that scope:

snipe-it/resources/views/locations/view.blade.php

Line 47 in c93e35e

{{ number_format($location->assets()->AssetsForShow()->count()) }}

Screen.Recording.2025-08-11.at.12.43.56.PM.mov

Additionally, code like this won't work:

snipe-it/resources/views/locations/view.blade.php

Line 185 in c93e35e

<div id="users" @class(['tab-pane','active' => $location->users->count() > 0 ]) >

since it will assign the active class to every tab with a count of over 0.

[snipe]

Quick note - it might be tempting to just add the ->AssetsForShow() scope to the methods, but that would mess up our isDeleteable() counts. It might also be tempting to add it to the assets API index controller that filters by location on that page, which we could probably do, but remember that there is an archived switch in the index, so we have to apply it to everything except that, otherwise the archived assets won't show when we actually want them to.

[snipe]

I've updated that blade to at least always show all of the icons, so we don't have to do the weird active thing anymore.

[TineUser]

@snipe: You asked: "Do you by any chance have a lot of archived assets?"

We only have 23 assets archived.

@snipe: You wrote: "In the meantime, if you want those numbers to agree, uncheck the "show archived in lists" checkbox in the admin settings > general."

We don't have this setting activated.

[snipe]

@TineUser - FYI:

• Current location: Assets that have that set as their location_id
• Default Location: Assets that have that location set as their rtd_location_id (aka default location)
• Assigned Assets: Assets that are checked out to that location_id

[TineUser]

@snipe: "Assigned Assets: Assets that are checked out to that location_id"

OK, our computer assets are checked out to users in the meanig of given to the user or assigned to the user. So regarding the location, only the columns for current location and default location will show other values than "0", right?