Create eslint-plugin-hpe-design-system

[taysea]

Add config rules that are specific to HPE Design System. Starting an issue to create a running list of rules:

• Suggestion for recommended icon usage, ex. "Prefer HomeRounded to Home", "Use Down instead of FormDown" (and any other form icons) Enhancement: icon-prefer-homerounded eslint-plugin-hpe-design-system#2, Enhancement: no-form-icons eslint-plugin-hpe-design-system#3
• Check for custom colors/HEX values -- non theme values: just warn or info in grommet but maybe use "error" in design system: Flag for non-theme namespace colors #51
• Check for size on Headings / other typography elements: Enhancement: heading-no-size eslint-plugin-hpe-design-system#1
• Avoid use of style prop: Prefer props or theme over inline styles #35
• Is there a way to check if a prop someone has applied is already the default prop for that component? and if so, suggest they can remove it: TBD
• Check for px values on size props like pad/margin/gap/width/height etc.: Flag for non t-shirt size values #52

[halocline]

Discussion points:

• Do HPE Design System rules belong on eslint-plugin-grommet? Or should eslint-plugin-grommet only contain rules related to general Grommet and accessibility best practices?
• When should a rule be a warning vs. error? Determined that rules should be warnings
• @taysea any other discussion points?

[ericsoderberghp]

Good questions!
If we expect to have more than just a couple of rules, I'm wondering if we should have eslint-plugin-hpe-design-system?

[taysea]

Right now I'm leaning towards creating eslint-plugin-hpe-design-system. It should extend the "recommended" config from eslint-plugin-grommet but exist as its own repo since rules will be more specific to HPE, as opposed to open source community.

Aligns with mentality to keep Grommet "open-source" focused.

[taysea]

eslint-plugin-hpe-design-system has been created: https://github.com/grommet/eslint-plugin-hpe-design-system/tree/main

Before closing this, I want to discuss the remaining checkbox items and if they're relevant more to grommet or HPE Design System

[taysea]

Closing this, issues have been created.