Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication should not be built in #8

Open
GeekOnCoffee opened this issue Sep 1, 2012 · 5 comments
Open

Authentication should not be built in #8

GeekOnCoffee opened this issue Sep 1, 2012 · 5 comments

Comments

@GeekOnCoffee
Copy link
Contributor

Summary from Spree's recent move to this:

Spree no longer ships with authentication included. Previous version of Spree have relied on a third pary library known as Devise. By removing the dependency on Devise this allows Spree to be more easily integrated with larger Rails applications that may have their own authentication system. For those that are using Devise (or have no strong preference for which system they use), we still have Devise support for Spree. You’ll just need to add the spree_auth_devise extension to your application.

http://guides.spreecommerce.com/authentication.html has information on how it's pulled off

@knewter
Copy link
Member

knewter commented Sep 1, 2012

+1, imo the biggest remaining hurdle to an uptick in a "Rails Engine Ecosystem" that is only just now maturing (a bit late)

@radar
Copy link

radar commented Feb 5, 2013

I like the idea of setting a class variable. It's worked well within Spree and Forem. With that value, then you constantize it and then assume that class follows a certain API. How we ensure that API is present, I don't know yet.

@knewter
Copy link
Member

knewter commented Feb 5, 2013

So we can define the API solidly, and then if your default user/auth doesn't implement it you can be responsible for implementing a wrapper that does.

@parndt
Copy link
Member

parndt commented Feb 5, 2013

So we can define the API solidly, and then if your default user/auth doesn't implement it you can be responsible for implementing a wrapper that does.

That's a bingo!

@johanb
Copy link
Member

johanb commented Feb 6, 2013

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants