Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

client-stream metrics don't invoked Handled on OK status #92

Open
jgraettinger opened this issue May 31, 2020 · 1 comment
Open

client-stream metrics don't invoked Handled on OK status #92

jgraettinger opened this issue May 31, 2020 · 1 comment

Comments

@jgraettinger
Copy link

See: https://github.com/grpc-ecosystem/go-grpc-prometheus/blob/master/client_metrics.go#L230-L244

The problem with this block is that CloseAndRecv of a client-only stream sends stream close, receives the single response message, and then never reads stream EOF which would cause Handle to be invoked.
jgraettinger added a commit to jgraettinger/gazette that referenced this issue May 31, 2020
@jgraettinger
client: add extra appender read of EOF
5ccd0ce 
work-around for grpc-ecosystem/go-grpc-prometheus#92
@jgraettinger
Copy link
Author

FWIW, a work-around is to add an extra RecvMsg, for purposes of draining the EOF & causing the interceptor to run.

jgraettinger added a commit to gazette/core that referenced this issue May 31, 2020
@jgraettinger
client: add extra appender read of EOF
4d0aca5 
work-around for grpc-ecosystem/go-grpc-prometheus#92
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgraettinger