Skip to content

stats/opentelemetry: Write e2e tests for tracing more than single message sent and received #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
purnesh42H opened this issue Apr 10, 2025 · 1 comment · May be fixed by #8242
Open

stats/opentelemetry: Write e2e tests for tracing more than single message sent and received #8240

purnesh42H opened this issue Apr 10, 2025 · 1 comment · May be fixed by #8242
Assignees
@vinothkumarr227
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. P2 Type: Testing

Comments

@purnesh42H
Copy link
Contributor

In all of the e2e tests, we only have single message being sent/received, which means that the logic on the sequence numbers incremented is untested. Write a separate test for streaming RPC where multiple messages are being sent and received and validate the traces accordingly
@purnesh42H purnesh42H added Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Feature New features or improvements in behavior Type: Testing P2 and removed Type: Feature New features or improvements in behavior labels Apr 10, 2025
@purnesh42H purnesh42H mentioned this issue Apr 10, 2025
Merged
@vinothkumarr227
Copy link
Contributor

@purnesh42H Please assign the issue to me.

@vinothkumarr227 vinothkumarr227 linked a pull request Apr 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinothkumarr227 vinothkumarr227

Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. P2 Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Streaming rpc sequence numbers vinothkumarr227/grpc-go
2 participants
@purnesh42H @vinothkumarr227