-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Open
Labels
Area: ObservabilityIncludes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP ObservabilityIncludes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP ObservabilityP2Status: Help WantedType: Bug
Description
The number of retries is currently tracked inside the attemptInfo here:
grpc-go/stats/opentelemetry/opentelemetry.go
Line 244 in e816736
| previousRPCAttempts uint32 |
And a new attemptInfo is created for every attempt here:
grpc-go/stats/opentelemetry/client_metrics.go
Line 155 in e816736
| func getOrCreateRPCAttemptInfo(ctx context.Context) (context.Context, *attemptInfo) { |
We need to track this in the callInfo instead, so that we can increment the number of retries for a call:
grpc-go/stats/opentelemetry/opentelemetry.go
Line 174 in e816736
| type callInfo struct { |
We had a PR that attempted to do this earlier: #8342, but it introduced a flaky test and therefore had to be rolled back.
Metadata
Metadata
Assignees
Labels
Area: ObservabilityIncludes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP ObservabilityIncludes Stats, Tracing, Channelz, Healthz, Binlog, Reflection, Admin, GCP ObservabilityP2Status: Help WantedType: Bug